Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use primordials in runtime/, part1 #11241

Merged
merged 4 commits into from
Jul 3, 2021
Merged

refactor: use primordials in runtime/, part1 #11241

merged 4 commits into from
Jul 3, 2021

Conversation

bartlomieju
Copy link
Member

Ref #11224

@bartlomieju bartlomieju mentioned this pull request Jul 3, 2021
Closed
67 tasks
lucacasonato
lucacasonato reviewed Jul 3, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bartlomieju Can you also update wrappedHandler.handler.call on line 34 or web_util.js?

Also URL on line 102 of 06_util.js comes from global scope right now. Could you instead import it from window.__bootstrap.url? Same for 11_workers.js.

lucacasonato
lucacasonato reviewed Jul 3, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bartlomieju bartlomieju merged commit 6137c80 into denoland:main Jul 3, 2021
@bartlomieju bartlomieju deleted the primordials_runtime_part1 branch July 3, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomieju @lucacasonato