chore: align fetch to spec #10203
Merged
chore: align fetch to spec #10203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
lucacasonato
force-pushed
the
body_align_to_spec
branch
from
dafb154
to
78fd950
Compare
aapoalas
reviewed
Apr 18, 2021
This was referenced Apr 18, 2021
lucacasonato
force-pushed
the
body_align_to_spec
branch
5 times, most recently
from
7f088a4
to
2695bc3
Compare
This commit aligns the `fetch` API and the `Request` / `Response` classes belonging to it to the spec. This commit enables all the relevant `fetch` WPT tests. Spec compliance is now at around 90%. This commit does introduce a approximately 45% performance reduction in the main `http` loop. The cause of this is a combination of the `ReadableStream` in the `InnerBody`, the webidl converters, and various other ineffciencies in the internals. Now that we have test coverage, these can be individualy addressed in follow up commits.
lucacasonato
force-pushed
the
body_align_to_spec
branch
from
2695bc3
to
34d629f
Compare
Improves throughput from 32k to 40k req/s on M1.
Lazily create the inner request / response body stream for static body. Improvement from 40k -> 44k req/s.
ry
approved these changes
Apr 20, 2021
| */ | ||
| function createHttpClient(options) { | ||
| return new HttpClient(core.opSync("op_create_http_client", options)); | ||
| } |
There was a problem hiding this comment.
Aside: we should get rid of Deno.createHttpClient, new Deno.HttpClient should be sufficient.
Liamolucko
added a commit
to Liamolucko/doc_website
that referenced
this pull request
Apr 25, 2021
Fixes denoland#189 I think they were made immutable when aligning `fetch` to spec in denoland/deno#10203
ghost
reviewed
May 2, 2021
Comment on lines
+224
to
+225
| if (mimeType !== null) { | ||
| if (mimeType !== null) { |
There was a problem hiding this comment.
Really late, but the nested if statement's else body is unreachable, you have a duplicate condition.
ghost
reviewed
May 2, 2021
| if (init.headers !== undefined) { | ||
| headers = init.headers; | ||
| } | ||
| headerListFromHeaders(this[_headers]).slice( |
There was a problem hiding this comment.
Array#slice doesn't it mutate the source, this is dead code. Maybe you wanted Array#splice?
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit aligns the
fetchAPI and theRequest/Responseclasses belonging to it to the spec. This commit enables all the
relevant
fetchWPT tests. Spec compliance is now at around 90%.Performance is essentially identical now (within 1% of 1.9).
Closes #10002