LSP: intellisense inserts ? after every completion

[lucacasonato]

All completions for optional fields of an object insert a ? after the property name in the completion. Issue here is likely that completion label should have the ? to mark that the completion is optional, but the actual edit text should not. Present in canary. Was introduced very recently, likely in #9789

[kitsonk]

Could you give a more specific example of what is/isn't working so I can reproduce it?

[lucacasonato]

issue.mp4

That question mark after object.bar shouldn't be added

[elisee]

Using latest canary, although the base bug is fixed, intellisense inserts an extra ? when completing further:

Possibly that's on purpose since a is null in this case? But the regular TypeScript extension doesn't do that and it feels weird to have a ? inserted on the parent property for me when autocompleting a child property (if I wanted it, I would have put it myself)

[kitsonk]

That it what it is supposed to do, because a maybe undefined. I'm pretty sure the regular TypeScript extension would do this too.

[elisee]

Ah, indeed. The TypeScript extension doesn't do it by default, which is why I found it strange, but I've just tested by explicitly setting "strict": true in tsconfig.json file and now it does. Since Deno has strict enabled by default, I guess that explains it. 👍