Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support import completions + cache quick fix in @deno-types and triple slash #9823

Closed
lucacasonato opened this issue Mar 18, 2021 · 1 comment · Fixed by #10699
Closed

Support import completions + cache quick fix in @deno-types and triple slash #9823

lucacasonato opened this issue Mar 18, 2021 · 1 comment · Fixed by #10699
Assignees
@kitsonk
Labels
feat new feature (which has been agreed to/accepted) lsp related to the language server

Comments

@lucacasonato
Copy link
Member

Follow up to #9821

We should support the cache quick fix, import diagnostics, and import completions for import specifiers in // @deno-types="" and /// <references types="" /> comments, like we did in the old extension.
@lucacasonato lucacasonato added feat new feature (which has been agreed to/accepted) lsp related to the language server labels Mar 18, 2021
@kitsonk kitsonk self-assigned this Apr 30, 2021
@kitsonk kitsonk mentioned this issue May 19, 2021
Merged
@kitsonk
Copy link
Contributor

kitsonk commented May 19, 2021

Add the completions is a bit more complicated than adding the diagnostics and the quick fixes, so first step is to add the diagnostics and quick fix. I will open another issue for completions.

@kitsonk kitsonk mentioned this issue May 19, 2021
Closed
kitsonk added a commit that referenced this issue May 25, 2021
@kitsonk
feat(lsp): diagnostics for deno types and triple-slash refs (#10699)
cd4194a 
Fixes #9823
piscisaureus pushed a commit that referenced this issue May 31, 2021
@kitsonk @piscisaureus
feat(lsp): diagnostics for deno types and triple-slash refs (#10699)
53d3dc4 
Fixes #9823
piscisaureus pushed a commit that referenced this issue May 31, 2021
@kitsonk @piscisaureus
feat(lsp): diagnostics for deno types and triple-slash refs (#10699)
bfc929e 
Fixes #9823
piscisaureus pushed a commit that referenced this issue May 31, 2021
@kitsonk @piscisaureus
feat(lsp): diagnostics for deno types and triple-slash refs (#10699)
52cc2ed 
Fixes #9823
piscisaureus pushed a commit that referenced this issue May 31, 2021
@kitsonk @piscisaureus
feat(lsp): diagnostics for deno types and triple-slash refs (#10699)
2dfed2e 
Fixes #9823
piscisaureus pushed a commit that referenced this issue May 31, 2021
@kitsonk @piscisaureus
feat(lsp): diagnostics for deno types and triple-slash refs (#10699)
900fac0 
Fixes #9823
piscisaureus pushed a commit that referenced this issue May 31, 2021
@kitsonk @piscisaureus
feat(lsp): diagnostics for deno types and triple-slash refs (#10699)
6bbefdf 
Fixes #9823
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kitsonk kitsonk

Labels
feat new feature (which has been agreed to/accepted) lsp related to the language server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(lsp): diagnostics for deno types and triple-slash refs kitsonk/deno
2 participants
@kitsonk @lucacasonato