You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently CLI uses Error.prepareStackTrace API to perform source mapping and formatting of errors.
This situation leads to overall complexity of this method as well as requirement to manually acquire information about stack frames as well as distributing the logic between JS and Rust.
We want to avoid jumping between JS and Rust as much as possible and to solve this problem in this situation we need to:
Add new APIs to V8's StackFrame to acquire the same data as using CallSite:
With recent improvements to error handling by @nayeemrmn done in #14378, #14394, #14302 and #14274 I feel this issue is no longer of high importance. Closing for now.
Currently CLI uses
Error.prepareStackTrace
API to perform source mapping and formatting of errors.This situation leads to overall complexity of this method as well as requirement to manually acquire information about stack frames as well as distributing the logic between JS and Rust.
We want to avoid jumping between JS and Rust as much as possible and to solve this problem in this situation we need to:
StackFrame
to acquire the same data as usingCallSite
:deno/cli/rt/40_error_stack.js
Lines 172 to 191 in d68fb81
prepareStackTrace
method fromcli/rt/40_error_stack.js
and instead useIsolate::set_prepare_stack_trace_callback
- needs to be added torusty_v8
firstCC @ry @nayeemrmn
The text was updated successfully, but these errors were encountered: