Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat: bundle installed script" #7492

Closed
bartlomieju opened this issue Sep 15, 2020 · 3 comments
Closed

Revert "feat: bundle installed script" #7492

bartlomieju opened this issue Sep 15, 2020 · 3 comments

Comments

@bartlomieju
Copy link
Member

Unfortunately users are having quite a few problems with bundling of installed script (eg. #7455).

We should revert this change for 1.4.1 and revisit the topic once we migrate bundling to SWC (#7461)
@bartlomieju
Copy link
Member Author

@kt3k could you look into this problem? I tried reverting but got a bit lost in the config bit...

@bartlomieju bartlomieju mentioned this issue Sep 16, 2020
Merged
piscisaureus added a commit to piscisaureus/deno that referenced this issue Sep 16, 2020
@piscisaureus
Revert "feat(install): bundle before installation" (denoland#7522)
bd75a01 
This reverts the changes introduced by PR denoland#5276, which made
`deno install «script»` automatically bundle the script's dependencies.
It broke the `deno install` command for a large number of scripts.

This reverts commit 34e98fa.

Closes: denoland#7492
@kt3k
Copy link
Member

kt3k commented Sep 16, 2020

I was able to reproduced the issue reported in #7455 with the following command:

deno bundle --unstable https://deno.land/x/[email protected]/cli.js > out.js
deno run out.js

I think it is caused by the bundler itself. (Maybe our bundler is not mature enough to handle general cases?) I'll look into it more tomorrow.

But I agree with reverting with #7522 for the moment.

@piscisaureus
Copy link
Member

I'd suggest to add the --bundle flag for now, so we can get some real life experience with it.

vitormmatos pushed a commit to vitormmatos/deno that referenced this issue Sep 21, 2020
@piscisaureus
Revert "feat(install): bundle before installation" (denoland#7522)
5f7ea53 
This reverts the changes introduced by PR denoland#5276, which made
`deno install «script»` automatically bundle the script's dependencies.
It broke the `deno install` command for a large number of scripts.

This reverts commit 34e98fa.

Closes: denoland#7492
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@piscisaureus @kt3k @bartlomieju