Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] dynamic import not working in bundles #4062

Closed
kitsonk opened this issue Feb 21, 2020 · 2 comments · Fixed by #4561
Closed

[bug] dynamic import not working in bundles #4062

kitsonk opened this issue Feb 21, 2020 · 2 comments · Fixed by #4561

Comments

@kitsonk
Copy link
Contributor

kitsonk commented Feb 21, 2020 •
edited
Loading

Dynamic import is not working in bundles. While the static analysis of the dependencies is occurring, the module specifier is being passed unmodified, which means it is up to the bundle code to resolve the specifier.

Also, importing of JSON doesn't work in the bundle. The source JSON is simply inlined into the bundle.
@kitsonk kitsonk mentioned this issue Feb 24, 2020
Closed
@kitsonk
Copy link
Contributor Author

kitsonk commented Mar 17, 2020

I believe this is an error in the emit from TypeScript and opened microsoft/TypeScript#37429.

@kitsonk
Copy link
Contributor Author

kitsonk commented Mar 17, 2020

It is under investigation, but it does seem like it won't be a quick fix, so if we want to support it, we might have to come up with some sort of alternative solution.

@kitsonk kitsonk mentioned this issue Mar 31, 2020
Closed
18 tasks
kitsonk added a commit to kitsonk/deno that referenced this issue Apr 1, 2020
@kitsonk
Support dynamic import in bundles.
7b96418 
Fixes denoland#4062
@kitsonk kitsonk mentioned this issue Apr 1, 2020
Merged
kitsonk added a commit to kitsonk/deno that referenced this issue Apr 2, 2020
@kitsonk
Support dynamic import in bundles.
340aaf6 
Fixes denoland#4062
@ry ry closed this as completed in #4561 Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support dynamic import in bundles. kitsonk/deno
1 participant
@kitsonk