Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in help message for new permission shorthand #25274

Closed
wldhg opened this issue Aug 28, 2024 · 0 comments · Fixed by #25962
Closed

Typo in help message for new permission shorthand #25274

wldhg opened this issue Aug 28, 2024 · 0 comments · Fixed by #25962
Assignees
@crowlKats
Labels
bug Something isn't working correctly cli related to cli/ dir docs

Comments

@wldhg
Copy link

wldhg commented Aug 28, 2024 •
edited
Loading

Version: Deno 1.46.1

It seems that there is a typo in this help message improvement commit -- (cli/args/flags.rs).

The shorthand -S appears to be attached as if it applies to both --allow-sys and --deny-sys.

And this is still present in the current main branch.
@lucacasonato lucacasonato added bug Something isn't working correctly cli related to cli/ dir docs labels Aug 29, 2024
@MujahedSafaa MujahedSafaa mentioned this issue Oct 1, 2024
Merged
crowlKats pushed a commit that referenced this issue Oct 1, 2024
@MujahedSafaa
fix: remove the typo in the help message (#25962)
2910438 
This PR fixes: #25274

Remove the extra shorthand -S that attached to the --deny-sys.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crowlKats crowlKats

Labels
bug Something isn't working correctly cli related to cli/ dir docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove the typo in the help message MujahedSafaa/deno
3 participants
@lucacasonato @crowlKats @wldhg