Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark page spinner doesn't disappear on Edge #2508

Closed
ry opened this issue Jun 12, 2019 · 2 comments
Closed

benchmark page spinner doesn't disappear on Edge #2508

ry opened this issue Jun 12, 2019 · 2 comments
Labels
benchmarks https://deno.land/benchmarks.html bug Something isn't working correctly

Comments

@ry
Copy link
Member

ry commented Jun 12, 2019

edge_benchmarks
@ry ry added benchmarks https://deno.land/benchmarks.html bug Something isn't working correctly labels Jun 12, 2019
@davidjamesstone
Copy link
Contributor

@ry, I can pick this up.

@davidjamesstone
Copy link
Contributor

I've tracked this issue down to Chakra-based versions of edge (pre-chromium) not supporting Promise.prototype.finally. I'll fix this tonight.

It works fine with new Chromium-based Edge version.

@davidjamesstone davidjamesstone mentioned this issue Jun 14, 2019
Merged
ry pushed a commit that referenced this issue Jun 15, 2019
@davidjamesstone @ry
Fixes benchmark page spinner on Edge #2508 (#2525)
76329cf
@ry ry closed this as completed Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
benchmarks https://deno.land/benchmarks.html bug Something isn't working correctly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ry @davidjamesstone