Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node:child_process's childProcess.kill() logs out ChildProcess.prototype.disconnect #22299

Closed
lucacasonato opened this issue Feb 6, 2024 · 0 comments · Fixed by #22488
Closed

node:child_process's childProcess.kill() logs out ChildProcess.prototype.disconnect #22299

lucacasonato opened this issue Feb 6, 2024 · 0 comments · Fixed by #22488
Assignees
@littledivy
Labels
bug Something isn't working correctly node compat

Comments

@lucacasonato
Copy link
Member

Calling node:child_process's childProcess.kill() logs out a Warning: Not implemented: ChildProcess.prototype.disconnect message. This does not happen in Node.

I think this was a bug introduced during @littledivy's recent work introducing Node IPC.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@littledivy littledivy

Labels
bug Something isn't working correctly node compat
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ext/node): unimplemented code when not IPC child_process littledivy/deno
2 participants
@lucacasonato @littledivy