-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
worker core dumped panic #12658
Comments
Although it's very rare, this code can also yield a Rust panic:
See #12713. |
Filed as a V8 bug: https://bugs.chromium.org/p/v8/issues/detail?id=12379 |
I've been looking into why the V8 bug doesn't crash Chrome, and it seems like what they do is, rather than terminating the worker's instance immediately, they:
Since Should we consider following the same model? |
Due to a bug in V8, terminating an isolate while a module with top-level await is being evaluated would crash the process. This change makes it so calling `worker.terminate()` will signal the worker to terminate at the next iteration of the event loop, and it schedules a proper termination of the worker's isolate after 2 seconds. Closes denoland#12658
This code has a chance to "panic" with a core dumped error on linux.
Both on deno 1.15.3 and canary(1.15.3+26a5471)
C stacktrace
The text was updated successfully, but these errors were encountered: