Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp: auto-completion for registries should prefer mod.ts #10441

Closed
kitsonk opened this issue Apr 30, 2021 · 4 comments
Closed

lsp: auto-completion for registries should prefer mod.ts #10441

kitsonk opened this issue Apr 30, 2021 · 4 comments
Assignees
Labels
feat new feature (which has been agreed to/accepted) lsp related to the language server

Comments

@kitsonk
Copy link
Contributor

kitsonk commented Apr 30, 2021

The lsp should prefer a /mod.ts over other imports when providing registry completions.

@kitsonk kitsonk added feat new feature (which has been agreed to/accepted) lsp related to the language server labels Apr 30, 2021
@kitsonk kitsonk self-assigned this Apr 30, 2021
@kitsonk
Copy link
Contributor Author

kitsonk commented Apr 30, 2021

Related: #10440

@lucacasonato
Copy link
Member

I think this should be done by registry providers. They can determine sort order right?

@kitsonk
Copy link
Contributor Author

kitsonk commented May 3, 2021

I have no problem leaving it up to the registries.

They can determine sort order right?

It is open to interpretation, we are setting a key that ensures that they get displayed in the order received, which is "convention" versus "specification". There is also the preferred flag in the response (only one can be marked preferred). So it would be best when we do v2 of the specification (including the incremental/partial lists) to provide explicit sort text and an explicit preferred flag.

@kitsonk
Copy link
Contributor Author

kitsonk commented Jun 24, 2021

We will leave as part of #10051.

@kitsonk kitsonk closed this as completed Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat new feature (which has been agreed to/accepted) lsp related to the language server
Projects
None yet
Development

No branches or pull requests

2 participants