Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lsp: auto-importing should prefer deps.ts #10440

Closed
Skillz4Killz opened this issue Aug 25, 2020 · 1 comment · Fixed by #20539
Closed

lsp: auto-importing should prefer deps.ts #10440

Skillz4Killz opened this issue Aug 25, 2020 · 1 comment · Fixed by #20539
Assignees
@nayeemrmn
Labels
feat new feature (which has been agreed to/accepted) lsp related to the language server

Comments

@Skillz4Killz
Copy link

Is your feature request related to a problem? Please describe.

When you import something automatically, it will opt for importing it from a url. It would be nice if that auto-import preferred importing it from deps.ts when that same import is exported from deps.ts

Describe the solution you'd like

Auto-imports prioritize importing from deps.ts
@Skillz4Killz
Copy link
Author

Bumping this as I just happened upon a slight issue from one of the users of my module. What happened is they were coding and auto-completion imported from the url instead of deps.ts.

VSC didn't show any errors. Recently, i updated the library and the user updated his deps.ts but continued to have issues. After quite a lot of debugging realizing the file actually was importing something from an older version of the library even though deps.ts was updated.

@kitsonk kitsonk self-assigned this Apr 5, 2021
@kitsonk kitsonk transferred this issue from denoland/vscode_deno Apr 30, 2021
@kitsonk kitsonk changed the title Prefer Importing From Deps.ts lsp: prefer Importing from mod.ts or deps.ts Apr 30, 2021
@kitsonk kitsonk changed the title lsp: prefer Importing from mod.ts or deps.ts lsp: auto-importing should prefer deps.ts Apr 30, 2021
@kitsonk kitsonk added feat new feature (which has been agreed to/accepted) lsp related to the language server labels Apr 30, 2021
@kitsonk kitsonk mentioned this issue Apr 30, 2021
Closed
@nayeemrmn nayeemrmn assigned nayeemrmn and unassigned kitsonk Sep 17, 2023
@nayeemrmn nayeemrmn mentioned this issue Sep 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nayeemrmn nayeemrmn

Labels
feat new feature (which has been agreed to/accepted) lsp related to the language server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(lsp): prefer local auto-import specifiers nayeemrmn/deno
3 participants
@kitsonk @Skillz4Killz @nayeemrmn