chore(cli): Reduce port conflict in tests (#19988)

Ports are still occasionally causing CI flake -- allocate and separate ports further for fetch/http tests.
denoland · Jul 31, 2023 · 43877f1 · 43877f1
1 parent 2fd8747
commit 43877f1
Show file tree

Hide file tree

Showing 2 changed files with 114 additions and 102 deletions.
diff --git a/cli/tests/unit/fetch_test.ts b/cli/tests/unit/fetch_test.ts
@@ -10,7 +10,7 @@ import {
 } from "./test_util.ts";
 import { Buffer } from "../../../test_util/std/io/buffer.ts";
 
-const listenPort = 4504;
+const listenPort = 4506;
 
 Deno.test(
   { permissions: { net: true } },
@@ -1909,7 +1909,7 @@ Deno.test(
   // https://github.com/denoland/deno/issues/18350
   { ignore: Deno.build.os === "windows", permissions: { net: true } },
   async function fetchRequestBodyErrorCatchable() {
-    const listener = Deno.listen({ hostname: "127.0.0.1", port: 4514 });
+    const listener = Deno.listen({ hostname: "127.0.0.1", port: listenPort });
     const server = (async () => {
       const conn = await listener.accept();
       listener.close();
@@ -1936,7 +1936,7 @@ Deno.test(
     });
 
     const err = await assertRejects(() =>
-      fetch("http://localhost:4514", {
+      fetch(`http://localhost:${listenPort}/`, {
         body: stream,
         method: "POST",
       })