chore: deprecate lint itests (#25655)

denoland · Sep 16, 2024 · 36a1a79 · 36a1a79
1 parent acc32e1
commit 36a1a79
Show file tree

Hide file tree

Showing 123 changed files with 814 additions and 299 deletions.
diff --git a/tests/integration/lint_tests.rs b/tests/integration/lint_tests.rs
diff --git a/tests/integration/mod.rs b/tests/integration/mod.rs
@@ -35,8 +35,6 @@ mod js_unit_tests;
 mod jsr;
 #[path = "jupyter_tests.rs"]
 mod jupyter;
-#[path = "lint_tests.rs"]
-mod lint;
 #[path = "lsp_tests.rs"]
 mod lsp;
 #[path = "node_unit_tests.rs"]

diff --git a/tests/specs/lint/all/__test__.jsonc b/tests/specs/lint/all/__test__.jsonc
@@ -0,0 +1,5 @@
+{
+  "args": "lint file1.js file2.ts ignored_file.ts",
+  "output": "expected.out",
+  "exitCode": 1
+}
diff --git a/tests/testdata/lint/expected.out → tests/specs/lint/all/expected.out b/tests/testdata/lint/expected.out → tests/specs/lint/all/expected.out
diff --git a/tests/testdata/lint/without_config/file1.js → tests/specs/lint/all/file1.js b/tests/testdata/lint/without_config/file1.js → tests/specs/lint/all/file1.js
diff --git a/tests/testdata/lint/without_config/file2.ts → tests/specs/lint/all/file2.ts b/tests/testdata/lint/without_config/file2.ts → tests/specs/lint/all/file2.ts
diff --git a/...tdata/lint/without_config/ignored_file.ts → tests/specs/lint/all/ignored_file.ts b/...tdata/lint/without_config/ignored_file.ts → tests/specs/lint/all/ignored_file.ts
diff --git a/tests/specs/lint/compact/__test__.jsonc b/tests/specs/lint/compact/__test__.jsonc
@@ -0,0 +1,5 @@
+{
+  "args": "lint --compact file1.js ignored_file.tss",
+  "output": "expected_compact.out",
+  "exitCode": 1
+}
diff --git a/tests/testdata/lint/expected_compact.out → ...s/specs/lint/compact/expected_compact.out b/tests/testdata/lint/expected_compact.out → ...s/specs/lint/compact/expected_compact.out
diff --git a/tests/specs/lint/compact/file1.js b/tests/specs/lint/compact/file1.js
@@ -0,0 +1,2 @@
+// deno-lint-ignore
+while (false) {}
diff --git a/tests/specs/lint/glob/__test__.jsonc b/tests/specs/lint/glob/__test__.jsonc
@@ -0,0 +1,5 @@
+{
+  "args": "lint --ignore=without_config/malformed.js,with_config/ without_config/",
+  "output": "expected_glob.out",
+  "exitCode": 1
+}
diff --git a/tests/testdata/lint/expected_glob.out → tests/specs/lint/glob/expected_glob.out b/tests/testdata/lint/expected_glob.out → tests/specs/lint/glob/expected_glob.out
diff --git a/tests/testdata/lint/with_config/a.ts → tests/specs/lint/glob/with_config/a.ts b/tests/testdata/lint/with_config/a.ts → tests/specs/lint/glob/with_config/a.ts
diff --git a/tests/testdata/lint/with_config/b.ts → tests/specs/lint/glob/with_config/b.ts b/tests/testdata/lint/with_config/b.ts → tests/specs/lint/glob/with_config/b.ts
diff --git a/tests/specs/lint/glob/without_config/file1.js b/tests/specs/lint/glob/without_config/file1.js
@@ -0,0 +1,2 @@
+// deno-lint-ignore
+while (false) {}
diff --git a/tests/specs/lint/glob/without_config/file2.ts b/tests/specs/lint/glob/without_config/file2.ts
@@ -0,0 +1,6 @@
+try {
+  await Deno.open("./some/file.txt");
+} catch (_e) {}
+
+// deno-lint-ignore no-explicit-any
+function _foo(): any {}
diff --git a/tests/specs/lint/glob/without_config/ignored_file.ts b/tests/specs/lint/glob/without_config/ignored_file.ts
@@ -0,0 +1,3 @@
+// deno-lint-ignore-file
+
+function foo(): any {}
diff --git a/...testdata/lint/without_config/malformed.js → ...ecs/lint/glob/without_config/malformed.js b/...testdata/lint/without_config/malformed.js → ...ecs/lint/glob/without_config/malformed.js
diff --git a/tests/specs/lint/ignore/__test__.jsonc b/tests/specs/lint/ignore/__test__.jsonc
@@ -0,0 +1,5 @@
+{
+  "args": "lint --ignore=without_config/file1.js,without_config/malformed.js,without_config/lint_with_config/ without_config",
+  "output": "expected_ignore.out",
+  "exitCode": 1
+}
diff --git a/tests/testdata/lint/expected_ignore.out → tests/specs/lint/ignore/expected_ignore.out b/tests/testdata/lint/expected_ignore.out → tests/specs/lint/ignore/expected_ignore.out
diff --git a/tests/specs/lint/ignore/without_config/file1.js b/tests/specs/lint/ignore/without_config/file1.js
@@ -0,0 +1,2 @@
+// deno-lint-ignore
+while (false) {}
diff --git a/tests/specs/lint/ignore/without_config/file2.ts b/tests/specs/lint/ignore/without_config/file2.ts
@@ -0,0 +1,6 @@
+try {
+  await Deno.open("./some/file.txt");
+} catch (_e) {}
+
+// deno-lint-ignore no-explicit-any
+function _foo(): any {}
diff --git a/tests/specs/lint/ignore/without_config/ignored_file.ts b/tests/specs/lint/ignore/without_config/ignored_file.ts
@@ -0,0 +1,3 @@
+// deno-lint-ignore-file
+
+function foo(): any {}
diff --git a/tests/specs/lint/ignore/without_config/malformed.js b/tests/specs/lint/ignore/without_config/malformed.js
@@ -0,0 +1,4 @@
+// deno-fmt-ignore-file
+
+// intentionally malformed file
+export class A B C
diff --git a/tests/specs/lint/ignore_unexplicit_files/__test__.jsonc b/tests/specs/lint/ignore_unexplicit_files/__test__.jsonc
@@ -0,0 +1,5 @@
+{
+  "args": "lint --ignore=./",
+  "output": "lint.out",
+  "exitCode": 1
+}
diff --git a/tests/specs/lint/ignore_unexplicit_files/lint.out b/tests/specs/lint/ignore_unexplicit_files/lint.out
@@ -0,0 +1 @@
+error: No target files found.
diff --git a/tests/specs/lint/json/__test__.jsonc b/tests/specs/lint/json/__test__.jsonc
@@ -0,0 +1,5 @@
+{
+  "args": "lint --json file1.js file2.ts ignored_file.ts malformed.js",
+  "output": "expected_json.out",
+  "exitCode": 1
+}
diff --git a/tests/testdata/lint/expected_json.out → tests/specs/lint/json/expected_json.out b/tests/testdata/lint/expected_json.out → tests/specs/lint/json/expected_json.out
diff --git a/tests/specs/lint/json/file1.js b/tests/specs/lint/json/file1.js
@@ -0,0 +1,2 @@
+// deno-lint-ignore
+while (false) {}
diff --git a/tests/specs/lint/json/file2.ts b/tests/specs/lint/json/file2.ts
@@ -0,0 +1,6 @@
+try {
+  await Deno.open("./some/file.txt");
+} catch (_e) {}
+
+// deno-lint-ignore no-explicit-any
+function _foo(): any {}
diff --git a/tests/specs/lint/json/ignored_file.ts b/tests/specs/lint/json/ignored_file.ts
@@ -0,0 +1,3 @@
+// deno-lint-ignore-file
+
+function foo(): any {}
diff --git a/tests/specs/lint/json/malformed.js b/tests/specs/lint/json/malformed.js
@@ -0,0 +1,4 @@
+// deno-fmt-ignore-file
+
+// intentionally malformed file
+export class A B C
diff --git a/tests/specs/lint/jsx/__test__.jsonc b/tests/specs/lint/jsx/__test__.jsonc
@@ -0,0 +1,16 @@
+{
+  "steps": [
+    {
+      "if": "windows",
+      "args": "lint main.jsx",
+      "output": "main_windows.out",
+      "exitCode": 1
+    },
+    {
+      "if": "unix",
+      "args": "lint main.jsx",
+      "output": "main_unix.out",
+      "exitCode": 1
+    }
+  ]
+}
diff --git a/tests/specs/lint/jsx/main.jsx b/tests/specs/lint/jsx/main.jsx
@@ -0,0 +1 @@
+const data = <div>hello</div>;