Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional process_creation_flags argument to _install_update_win() #90

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

dennisvang
Copy link
Owner

The optional process_creation_flags argument allows users to override the process creation flags used for the subprocess call that runs the windows batch script that does the actual installation (i.e. moving files into place).

The process_creation_flags argument accepts subprocess Windows constants.

The default value remains subprocess.CREATE_NEW_CONSOLE, as before.

Usage example:

client.download_and_apply_update(..., process_creation_flags=subprocess.CREATE_NO_WINDOW)

fixes #81

@dennisvang dennisvang merged commit 35462d9 into master Nov 8, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to suppress install console on windows
1 participant