Fix formatter (#7)

* 🐛 string formatting
denkiwakame · Jan 12, 2019 · 16f6a0e · 16f6a0e
1 parent 4e36110
commit 16f6a0e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/.gitignore b/.gitignore
@@ -0,0 +1,2 @@
+dist/*
+packages/*
diff --git a/src/js/popup.js b/src/js/popup.js
@@ -118,7 +118,7 @@ UI = {
         for (author of data.authors) {
             const templateStr = require('../html/_chip.html');
             const compiled = _.template(templateStr);
-            const chipEl = self._str2elem( compiled({ tag: author.replace(/\ /g, '_') }) );
+            const chipEl = self._str2elem( compiled({ tag: author.trim().replace(/\ +/g, '_') }) );
             $(".mdc-chip-set").append(chipEl);
             self.chipSet.addChip(chipEl);
         }
@@ -146,11 +146,12 @@ App = {
     },
     getPaperInfo: function(url) {
         const self = this;
-//         const url_ = "http://openaccess.thecvf.com/content_ECCV_2018/papers/Martin_Sundermeyer_Implicit_3D_Orientation_ECCV_2018_paper.pdf";
-//         self.getPDFInfo(url_);
         if (self.isArxivUrl(url)) return self.getArXivInfo(url);
         if (self.isPDF(url)) return self.getPDFInfo(url); 
     },
+    formatString: function(str) {
+        return str.trim().replace(/\n/g,' ').replace(/\ +/g, ' ');
+    },
     getArXivInfo: function(url) {
         UI.showProgressBar();
         const self = this;
@@ -165,8 +166,8 @@ App = {
             statusCode: {
                 200: (data)=> {
                     const $entry= $(data).find("entry");
-                    const paperTitle = $entry.find("title")[0].textContent.replace(/\n/g,' ');    // FIXME
-                    const abst = $entry.find("summary")[0].textContent.trim().replace(/\n/g,' '); // FIXME
+                    const paperTitle = self.formatString($entry.find("title")[0].textContent);
+                    const abst = self.formatString($entry.find("summary")[0].textContent);
                     const authors = _.map($entry.find("author"), (a) => { return a.textContent.trim(); });
                     UI.setFormContents({
                         url         : url,
@@ -190,8 +191,8 @@ App = {
         const pdfLoading = pdfjsLib.getDocument(url);
         pdfLoading.promise.then((pdf)=>{
             pdf.getMetadata().then((d)=>{
-                const authors = d.info.Author.trim().replace("/ /_/g").split(",");
-                const paperTitle = d.info.Title.replace(/\n/g,' ');
+                const authors = d.info.Author.trim().split(",");
+                const paperTitle = self.formatString(d.info.Title);
                 UI.setFormContents({
                     url         : url,
                     paperTitle  : paperTitle,