Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navi widget does not always consider the "overrides" option #553

Closed
bimlas opened this issue May 20, 2021 · 2 comments · Fixed by #568
Closed

Navi widget does not always consider the "overrides" option #553

bimlas opened this issue May 20, 2021 · 2 comments · Fixed by #568
Labels
bug Something isn't working

Comments

@bimlas
Copy link
Contributor

bimlas commented May 20, 2021

Describe the bug

The following setting (--preview-window=down) is ignored if I press C-g in an empty prompt, only the "fallback" Navi appear as desired.

~/.config/navi/config.yaml

finder:
  command: fzf
    overrides: --no-select-1 --preview-window=down
    overrides_var: --no-select-1 --preview-window=down

To Reproduce

  1. Open an empty shell
  2. Press C-g to activate the Navi widget
  3. Notice the preview window is on the top (wrong behaviour)
  4. Press Esc and notice the preview window on the bottom (right behaviour)

Other path:

  1. Open an empty shell
  2. Enter text that Navi will recognize as a command that has parameter substitution
  3. Press C-g to activate the Navi widget
  4. Notice the preview window is on the down for the first time (right behaviour)

Expected behavior

Show the preview window on the bottom in every cases.

Versions:

  • OS: Ubuntu 20.04.2 LTS
  • Shell Version: zsh 5.8 (x86_64-ubuntu-linux-gnu)
  • Navi: navi 2.16.0

Additional context

Related issue: #546

@bimlas bimlas added the bug Something isn't working label May 20, 2021
@bimlas
Copy link
Contributor Author

bimlas commented May 20, 2021

I think this may be because the widget overrides option --fzf-overrides:

replacement="$(_navi_call --print --fzf-overrides '--no-select-1')"

@bimlas
Copy link
Contributor Author

bimlas commented May 20, 2021

I modified the copy of the widget code (removed --fzf-overrides '--no-select-1' from the line above), so for me this error has been fixed, but for others it is still alive.

denisidoro added a commit that referenced this issue Aug 7, 2021
bimlas added a commit to bimlas/home that referenced this issue Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant