Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Rich Text Files are not inspected with 'Extract Indicators From File - Generic v2' #3822

Merged
merged 5 commits into from
Jul 9, 2019

Conversation

DeanArbel
Copy link
Contributor

@DeanArbel DeanArbel commented Jul 7, 2019

Status

Ready

Related Issues

fixes: https://github.com/demisto/etc/issues/17655

Description

Fixed

  • playbook to handle a bug where .rtf files are not inspected with Extract Indicators From File - Generic v2.
  • bug in ExtractIndicatorsFromTextFile script where certain strings had their escape characters removed, which created impossible characters (which threw an exception).
  • Follow up of a previous bug that I noticed while working on this - in https://github.com/demisto/etc/issues/17351. (look for the next part in the comments).
    Though there is a condition prior to this task that was fixed, I realised that in a multi-file scenario this task might still be reached, and so this task had to be changed as well

Required version of Demisto

4.1.0+

Does it break backward compatibility?

  • No

Screenshots:

Before:

Playbook:

image

Script (before + after):

image

After:

Playbook:

image

Script (before + after):

image

Must have

  • Tests
  • Documentation
  • Code Review

@@ -632,22 +648,6 @@ tasks:
right:
value:
simple: Microsoft Word
- operator: isEqualString
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is a follow up of a previous bug that I noticed while working on this - in https://github.com/demisto/etc/issues/17351.
Though there is a condition prior to this task that was fixed, I realised that in a multi-file scenario this task might still be reached, and so this task had to be changed as well

@DeanArbel DeanArbel merged commit 96f8254 into master Jul 9, 2019
@DeanArbel DeanArbel deleted the extract-indctrs-fix branch July 9, 2019 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants