Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes - Cleanroom recovery action #36068

Merged

Conversation

Cv-securityIQ
Copy link
Contributor

@Cv-securityIQ Cv-securityIQ commented Aug 29, 2024

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Fix for issues as below:

  1. virtualmachines api not returning all the VMs
  2. Use clean room specific recovery group
  3. Inherit entity rather than group to set point in time recovery epoch
  4. Preserve VM name case while adding it to clean room.

Must have

  • Tests
  • Documentation

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Aug 29, 2024
@content-bot content-bot changed the base branch from master to contrib/Cv-securityIQ_master August 29, 2024 06:17
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @barryyosi-panw will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @Cv-securityIQ, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

@content-bot content-bot added Contribution Form Filled Whether contribution form filled or not. Partner labels Aug 29, 2024
@edik24 edik24 self-assigned this Aug 29, 2024
Copy link
Contributor

@barryyosi-panw barryyosi-panw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Cv-securityIQ, thank you for your contribution!
Please describe the bug you're fixing in this PR's description.

There are a couple of comment I left, pre-commit errors and failing validations (regarding missing release notes and versioning) that are to be addressed.

Thanks

@barryyosi-panw barryyosi-panw added the pending-contributor The PR is pending the response of its creator label Aug 29, 2024
@CLAassistant
Copy link

CLAassistant commented Sep 3, 2024

CLA assistant check
All committers have signed the CLA.

@barryyosi-panw barryyosi-panw merged commit 3e46e34 into demisto:contrib/Cv-securityIQ_master Sep 5, 2024
18 checks passed
Copy link

github-actions bot commented Sep 5, 2024

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

barryyosi-panw added a commit that referenced this pull request Sep 5, 2024
* Adding new action details in readme

* Bug fixes cleanroom action

* Bug Fixes - Cleanroom recovery action

* Readme changes for cleanroom recovery changes

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Update pack_metadata.json

* Update Packs/CommvaultSecurityIQ/README.md

---------

Co-authored-by: Cv-securityIQ <[email protected]>
Co-authored-by: barryyosi-panw <[email protected]>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Sep 10, 2024
* Adding new action details in readme

* Bug fixes cleanroom action

* Bug Fixes - Cleanroom recovery action

* Readme changes for cleanroom recovery changes

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Update pack_metadata.json

* Update Packs/CommvaultSecurityIQ/README.md

---------

Co-authored-by: Cv-securityIQ <[email protected]>
Co-authored-by: barryyosi-panw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved pending-contributor The PR is pending the response of its creator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants