Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FileCreateAndUploadV2] Fix An Issue With entryId Argument #33611

Merged
merged 11 commits into from
Mar 31, 2024

Conversation

shmuel44
Copy link
Contributor

@shmuel44 shmuel44 commented Mar 27, 2024

Related Issues

fixes: link to the issue

Description

  • Fixed an issue where the script returned an empty file when using the entryId argument.
  • Updated the script context path to support file entry context output.
  • Added TPB

Must have

  • Tests
  • Documentation

@shmuel44 shmuel44 self-assigned this Mar 27, 2024
@shmuel44 shmuel44 requested a review from dorschw March 27, 2024 20:28
Copy link
Contributor

@dorschw dorschw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@shmuel44 shmuel44 requested a review from dorschw March 28, 2024 12:48
@shmuel44 shmuel44 marked this pull request as ready for review March 28, 2024 12:52
@shmuel44 shmuel44 requested review from ShirleyDenkberg and removed request for ShirleyDenkberg March 28, 2024 14:06
@ShirleyDenkberg
Copy link
Contributor

@dorschw @sapirshuker Doc review completed.

@shmuel44 shmuel44 merged commit 0485a84 into master Mar 31, 2024
20 checks passed
@shmuel44 shmuel44 deleted the sk_CIAC_9940_file branch March 31, 2024 06:26
pal-xmco pushed a commit to pal-xmco/content that referenced this pull request Jun 19, 2024
…#33611)

* fix

* fix pre commit

* update conf.json

* Apply suggestions from code review

Co-authored-by: dorschw <[email protected]>

* fix CR

* fix ruff

* Apply suggestions from code review

Co-authored-by: dorschw <[email protected]>

* improve UT

---------

Co-authored-by: dorschw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants