Improve Fetch incidents structure and add append notes funcitonality #33436
Conversation
* Simplify fetch_incidents method to avoid duplicate incidents change alert ids to str to facilitate storage and comparison add set to avoid duplicates delete unnecessary timestamp fields in last_run reduce fetch_incidents to a single http call to alerts endpoint * Add PR comments on fixing type hints and polishing tests --------- Co-authored-by: Diego Ramirez <[email protected]>
remove get_alert_attachment_command to avoid confusing customers
DNRRomero
force-pushed
the
fix_duplicates
branch
2 times, most recently
from
fa13f27
to
533f859
Compare
DNRRomero
force-pushed
the
fix_duplicates
branch
from
533f859
to
4db22fd
Compare
jbabazadeh
requested review from
merit-maita
and removed request for
jbabazadeh
|
Hi @merit-maita we've had some issues with setting the release notes, as the pipeline shows internal errors |
it's fine, the rn validator is expected to fail. |
merit-maita
added
the
pending-contributor
|
Hi @merit-maita PR comments are ready, when could you be available for presenting you a demo? |
|
Hi @merit-maita we can give you a demo of the changes whenever you prefer between 8am and 4pm ET |
|
@DNRRomero can we set the demo for Monday 8:00 am ET? |
|
@merit-maita I did not see this message on time, as we start at 8 am ET, can we do it tomorrow (tuesday) at 10am ET? |
i have meeting at 10:00 ET, maybe 9:30 ET? |
|
@merit-maita 9:30 works for me! |
because of the time difference, we always miss setting up the meeting, so please once you see this comment, set up a meeting at 9:30, today or tomorrow. my email is [email protected] |
|
@dramirez-SR the meeting has no link to a zoom or teams meeting. |
|
@DNRRomero thank you for the demo! |
|
Hi @merit-maita ! merge conflict has been resolved |
merit-maita
merged commit 0ab3835
into
demisto:contrib/DNRRomero_fix_duplicates
|
Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days. |
…33912) * Improve Fetch incidents structure and add append notes funcitonality (#33436) * fix duplicate alerts (#123) * Simplify fetch_incidents method to avoid duplicate incidents change alert ids to str to facilitate storage and comparison add set to avoid duplicates delete unnecessary timestamp fields in last_run reduce fetch_incidents to a single http call to alerts endpoint * Add PR comments on fixing type hints and polishing tests --------- Co-authored-by: Diego Ramirez <[email protected]> * fix pre-commit formatting issues * remove get_alert_attachment command remove get_alert_attachment_command to avoid confusing customers * Add notes append test * format according to autopep8 * Update app versioning and add release notes * Change release version to 2.0.0 due to breaking compatibility * Undo version bump to 2.0.0 as it was not required, move back to 1.3.1 and mark as breaking change * Restore get_alert_attachments command and mark as deprecated, as per PR comments * Add sort field for fetching alerts given last_modified_min_date * pre-commit * added rn --------- Co-authored-by: Diego Ramirez R <[email protected]> Co-authored-by: merit-maita <[email protected]> Co-authored-by: merit-maita <[email protected]>
…emisto#33912) * Improve Fetch incidents structure and add append notes funcitonality (demisto#33436) * fix duplicate alerts (demisto#123) * Simplify fetch_incidents method to avoid duplicate incidents change alert ids to str to facilitate storage and comparison add set to avoid duplicates delete unnecessary timestamp fields in last_run reduce fetch_incidents to a single http call to alerts endpoint * Add PR comments on fixing type hints and polishing tests --------- Co-authored-by: Diego Ramirez <[email protected]> * fix pre-commit formatting issues * remove get_alert_attachment command remove get_alert_attachment_command to avoid confusing customers * Add notes append test * format according to autopep8 * Update app versioning and add release notes * Change release version to 2.0.0 due to breaking compatibility * Undo version bump to 2.0.0 as it was not required, move back to 1.3.1 and mark as breaking change * Restore get_alert_attachments command and mark as deprecated, as per PR comments * Add sort field for fetching alerts given last_modified_min_date * pre-commit * added rn --------- Co-authored-by: Diego Ramirez R <[email protected]> Co-authored-by: merit-maita <[email protected]> Co-authored-by: merit-maita <[email protected]>
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Must have