Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SentinelOne V2- 3.2.23 #33422

Conversation

munna-metron
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

Copy link
Contributor

@merit-maita merit-maita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the contribution, it looks good!
let's please set up ca short demo.

@merit-maita merit-maita added the pending-demo Demo pending label Mar 20, 2024
@merit-maita
Copy link
Contributor

Demo is set on Wednesday 11:30 AM

@@ -1146,28 +1154,29 @@ def get_threats_command(client: Client, args: dict) -> CommandResults:

def get_hash_command(client: Client, args: dict) -> CommandResults:
"""
Get hash reputation.
Get hash verdict.
Copy link
Contributor

@kgal-pan kgal-pan Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As suggested in the demo, this command can be replaced to use !file reputation command. See https://xsoar.pan.dev/docs/integrations/generic-commands-reputation and
https://xsoar.pan.dev/docs/integrations/context-and-outputs#return-filehash-reputation for more details.

@kgal-pan kgal-pan added post-demo and removed pending-demo Demo pending labels Mar 27, 2024
@merit-maita merit-maita added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Mar 31, 2024
@merit-maita merit-maita added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Mar 31, 2024
@merit-maita merit-maita self-requested a review March 31, 2024 09:42
@merit-maita merit-maita merged commit 22d454b into demisto:contrib/munna-metron_SentinelOne_v2_3.2.23 Mar 31, 2024
24 of 27 checks passed
Copy link

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

merit-maita added a commit that referenced this pull request Mar 31, 2024
* SentinelOne V2- 3.2.23 (#33422)

* Migrated the deprecated /rank endpoint to /verdict for sentinelone-get-hash command

* Fixed the typo for the word verdict

* reverted the commonscript changes

* Updated the markdown text from rank to verdict

---------

Co-authored-by: saurabh-metron <[email protected]>
Co-authored-by: merit-maita <[email protected]>

* Update Packs/SentinelOne/Integrations/SentinelOne-V2/SentinelOne-V2.yml

* Update Packs/SentinelOne/Integrations/SentinelOne-V2/README.md

---------

Co-authored-by: munna-metron <[email protected]>
Co-authored-by: saurabh-metron <[email protected]>
Co-authored-by: merit-maita <[email protected]>
@DavinGeorgeSentinelOne
Copy link

Hi Team, do we know when this will be released please?

@kgal-pan
Copy link
Contributor

kgal-pan commented Apr 2, 2024

pal-xmco pushed a commit to pal-xmco/content that referenced this pull request Jun 19, 2024
* SentinelOne V2- 3.2.23 (demisto#33422)

* Migrated the deprecated /rank endpoint to /verdict for sentinelone-get-hash command

* Fixed the typo for the word verdict

* reverted the commonscript changes

* Updated the markdown text from rank to verdict

---------

Co-authored-by: saurabh-metron <[email protected]>
Co-authored-by: merit-maita <[email protected]>

* Update Packs/SentinelOne/Integrations/SentinelOne-V2/SentinelOne-V2.yml

* Update Packs/SentinelOne/Integrations/SentinelOne-V2/README.md

---------

Co-authored-by: munna-metron <[email protected]>
Co-authored-by: saurabh-metron <[email protected]>
Co-authored-by: merit-maita <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved post-demo ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants