Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic SQL - Add support to SAP HANA #33025

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

RotemAmit
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Added support to SAP HANA in the Generic SQL integration.

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented Feb 20, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/GenericSQL/Integrations/GenericSQL
   GenericSQL.py33713360%28–29, 50, 99, 101, 103, 105, 107, 114–115, 118–122, 141, 159–160, 162, 165–172, 199, 205–206, 208, 290–291, 293, 295–296, 298–301, 303–304, 307–309, 311–312, 315–316, 319–323, 327–328, 330–333, 335, 337–339, 341, 343–344, 346–347, 349–350, 352, 401, 404–407, 457, 482, 502, 506, 608–638, 642, 648–653, 655–658, 661, 664–672
TOTAL33713360% 

Tests Skipped Failures Errors Time
29 1 💤 0 ❌ 0 🔥 2.147s ⏱️

@RotemAmit RotemAmit marked this pull request as ready for review February 20, 2024 14:32
Copy link
Contributor

@eyalpalo eyalpalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@CLAassistant
Copy link

CLAassistant commented Dec 3, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants