add a way to upload binary file #30532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi @Winultimatum,
Thank you for your contribution!Good work :)
Plesae see my comments,
We're ready for a demo. Please check this page, and let me know when you're available for one over DFIR.
Please feel free to reach out to me with any questions - I'm available here or on slack :)
Thanks again
Packs/XSOARFileManagement/Integrations/XSOARFileManagement/XSOARFileManagement.py
Outdated
Show resolved
Hide resolved
Packs/XSOARFileManagement/Integrations/XSOARFileManagement/XSOARFileManagement.py
Show resolved
Hide resolved
MosheEichler
added
pending-demo
Co-authored-by: Moshe Eichler <[email protected]>
MosheEichler
approved these changes
Nov 2, 2023
MosheEichler
merged commit 60c771c
into
demisto:contrib/Winultimatum_Improvement_XSOAR_File_Management
11 of 13 checks passed
MosheEichler
added a commit
that referenced
this pull request
Nov 2, 2023
* add a way to upload binary file (#30532) * add a way to upload binary file * patch ci/cd error * patch ci/cd error * Apply suggestions from code review Co-authored-by: Moshe Eichler <[email protected]> --------- Co-authored-by: Pierre SOLER <[email protected]> Co-authored-by: Moshe Eichler <[email protected]> * Update Docker Image To demisto/crypto (#30624) * Updated Metadata Of Pack AzureSecurityCenter * Added release notes to pack AzureSecurityCenter * Packs/AzureSecurityCenter/Integrations/AzureSecurityCenter_v2/AzureSecurityCenter_v2.yml Docker image update * fix jira convert issues print (#30608) fix jira convert issues print #30608 * fix merge dev secrets and sync buckets (#30609) fix merge dev secrets and sync buckets #30609 * Fixed Gitlab event collector fetch (#30379) * Fix GitLab collector * release notes * pre-commit fix * pre-commit fix * increase coverage * CR fixes * fix * Update 2_2_19.md * CR fix * default limit to 500 * update docker * Remove checking 6.2 server version (#30351) * removed usage of is_ge_version function with server version less than 6.2.0. * added rn * updated docker image * added rn * removed unit tests * fixed unittests * edit unittest * fixed unittest * edited unittests * edited unittests * mypy fixes * fixes * fixes * updated docker image * added rn * mypy fixes * edited unittests * edit * edit unit tests * edited the tpb to work with ng server * edited tpb * removed paging unit tests, removed arguments * reverted removing the args * Fix for dhcp (#30610) * Updated the modeling rule of microsoft dhcp * Updated the modeling rule of microsoft dhcp * Update 1_0_3.md --------- Co-authored-by: eepstain <[email protected]> * Xdr lite playbbok (#30497) * new incidents fields * New playbook,incident type,script,layout for xdr lite changing integration default incident type and classifier * resolve conflicts - RN * update RN, update unsearchable to true in incident fields and remove unnecessary incident fields from the layout * updated layout - InvestigationVerdict dynamic section * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <[email protected]> * fixes after review * Update Packs/CortexXDR/Scripts/InvestigationVerdict/README.md Co-authored-by: ShirleyDenkberg <[email protected]> * fix for test playbooks Test_XDR_Playbook_execute_script_commands.yml * fix after review. change script name * RN after fixes * RN after fixes * change name of the script yml file in pack ignore * lint fix * time range fix --------- Co-authored-by: ShirleyDenkberg <[email protected]> * comment out us its looks unused and adding unchanged_files to the changed_files (#30632) * OpsGenie v3 - Fix polling commands (#30579) * fix get_request_command method * update RN * validate results.content is not empty * add "." to missing descriptions * added test_get_request_command_valid_raw_response * fix mypy * fix flake8 * [Marketplace Contribution] Atlassian Jira - Content Pack Update (#30512) * [Marketplace Contribution] Atlassian Jira - Content Pack Update (#29838) * "contribution update to pack "Atlassian Jira"" * Update YML * Update Readme * Add missing docstrings * Apply suggestions from code review Co-authored-by: anas-yousef <[email protected]> Co-authored-by: omerKarkKatz <[email protected]> * Adjust response type to empty body response * Added periods on various strings, per pre-commit test failure * Unit tests for JIRA assignee --------- Co-authored-by: 68zuhKQfKPk <[email protected]> Co-authored-by: kPKfQKhuz86 <[email protected]> Co-authored-by: anas-yousef <[email protected]> Co-authored-by: omerKarkKatz <[email protected]> Co-authored-by: Jakob Weinzettl <[email protected]> * updated docker and fixed RN * added self to the class function * restored some yml marketplace download changeS * fixed the unit test * typing --------- Co-authored-by: xsoar-bot <[email protected]> Co-authored-by: 68zuhKQfKPk <[email protected]> Co-authored-by: kPKfQKhuz86 <[email protected]> Co-authored-by: anas-yousef <[email protected]> Co-authored-by: omerKarkKatz <[email protected]> Co-authored-by: Jakob Weinzettl <[email protected]> Co-authored-by: okarkkatz <[email protected]> --------- Co-authored-by: Pierre <[email protected]> Co-authored-by: Pierre SOLER <[email protected]> Co-authored-by: Moshe Eichler <[email protected]> Co-authored-by: Koby Meir <[email protected]> Co-authored-by: Yaakov Praisler <[email protected]> Co-authored-by: merit-maita <[email protected]> Co-authored-by: yasta5 <[email protected]> Co-authored-by: eepstain <[email protected]> Co-authored-by: OmriItzhak <[email protected]> Co-authored-by: ShirleyDenkberg <[email protected]> Co-authored-by: Moshe Galitzky <[email protected]> Co-authored-by: Adi Daud <[email protected]> Co-authored-by: xsoar-bot <[email protected]> Co-authored-by: 68zuhKQfKPk <[email protected]> Co-authored-by: kPKfQKhuz86 <[email protected]> Co-authored-by: anas-yousef <[email protected]> Co-authored-by: omerKarkKatz <[email protected]> Co-authored-by: Jakob Weinzettl <[email protected]> Co-authored-by: okarkkatz <[email protected]> Co-authored-by: MosheEichler <[email protected]>
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
* add a way to upload binary file (#30532) * add a way to upload binary file * patch ci/cd error * patch ci/cd error * Apply suggestions from code review Co-authored-by: Moshe Eichler <[email protected]> --------- Co-authored-by: Pierre SOLER <[email protected]> Co-authored-by: Moshe Eichler <[email protected]> * Update Docker Image To demisto/crypto (#30624) * Updated Metadata Of Pack AzureSecurityCenter * Added release notes to pack AzureSecurityCenter * Packs/AzureSecurityCenter/Integrations/AzureSecurityCenter_v2/AzureSecurityCenter_v2.yml Docker image update * fix jira convert issues print (#30608) fix jira convert issues print #30608 * fix merge dev secrets and sync buckets (#30609) fix merge dev secrets and sync buckets #30609 * Fixed Gitlab event collector fetch (#30379) * Fix GitLab collector * release notes * pre-commit fix * pre-commit fix * increase coverage * CR fixes * fix * Update 2_2_19.md * CR fix * default limit to 500 * update docker * Remove checking 6.2 server version (#30351) * removed usage of is_ge_version function with server version less than 6.2.0. * added rn * updated docker image * added rn * removed unit tests * fixed unittests * edit unittest * fixed unittest * edited unittests * edited unittests * mypy fixes * fixes * fixes * updated docker image * added rn * mypy fixes * edited unittests * edit * edit unit tests * edited the tpb to work with ng server * edited tpb * removed paging unit tests, removed arguments * reverted removing the args * Fix for dhcp (#30610) * Updated the modeling rule of microsoft dhcp * Updated the modeling rule of microsoft dhcp * Update 1_0_3.md --------- Co-authored-by: eepstain <[email protected]> * Xdr lite playbbok (#30497) * new incidents fields * New playbook,incident type,script,layout for xdr lite changing integration default incident type and classifier * resolve conflicts - RN * update RN, update unsearchable to true in incident fields and remove unnecessary incident fields from the layout * updated layout - InvestigationVerdict dynamic section * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <[email protected]> * fixes after review * Update Packs/CortexXDR/Scripts/InvestigationVerdict/README.md Co-authored-by: ShirleyDenkberg <[email protected]> * fix for test playbooks Test_XDR_Playbook_execute_script_commands.yml * fix after review. change script name * RN after fixes * RN after fixes * change name of the script yml file in pack ignore * lint fix * time range fix --------- Co-authored-by: ShirleyDenkberg <[email protected]> * comment out us its looks unused and adding unchanged_files to the changed_files (#30632) * OpsGenie v3 - Fix polling commands (#30579) * fix get_request_command method * update RN * validate results.content is not empty * add "." to missing descriptions * added test_get_request_command_valid_raw_response * fix mypy * fix flake8 * [Marketplace Contribution] Atlassian Jira - Content Pack Update (#30512) * [Marketplace Contribution] Atlassian Jira - Content Pack Update (#29838) * "contribution update to pack "Atlassian Jira"" * Update YML * Update Readme * Add missing docstrings * Apply suggestions from code review Co-authored-by: anas-yousef <[email protected]> Co-authored-by: omerKarkKatz <[email protected]> * Adjust response type to empty body response * Added periods on various strings, per pre-commit test failure * Unit tests for JIRA assignee --------- Co-authored-by: 68zuhKQfKPk <[email protected]> Co-authored-by: kPKfQKhuz86 <[email protected]> Co-authored-by: anas-yousef <[email protected]> Co-authored-by: omerKarkKatz <[email protected]> Co-authored-by: Jakob Weinzettl <[email protected]> * updated docker and fixed RN * added self to the class function * restored some yml marketplace download changeS * fixed the unit test * typing --------- Co-authored-by: xsoar-bot <[email protected]> Co-authored-by: 68zuhKQfKPk <[email protected]> Co-authored-by: kPKfQKhuz86 <[email protected]> Co-authored-by: anas-yousef <[email protected]> Co-authored-by: omerKarkKatz <[email protected]> Co-authored-by: Jakob Weinzettl <[email protected]> Co-authored-by: okarkkatz <[email protected]> --------- Co-authored-by: Pierre <[email protected]> Co-authored-by: Pierre SOLER <[email protected]> Co-authored-by: Moshe Eichler <[email protected]> Co-authored-by: Koby Meir <[email protected]> Co-authored-by: Yaakov Praisler <[email protected]> Co-authored-by: merit-maita <[email protected]> Co-authored-by: yasta5 <[email protected]> Co-authored-by: eepstain <[email protected]> Co-authored-by: OmriItzhak <[email protected]> Co-authored-by: ShirleyDenkberg <[email protected]> Co-authored-by: Moshe Galitzky <[email protected]> Co-authored-by: Adi Daud <[email protected]> Co-authored-by: xsoar-bot <[email protected]> Co-authored-by: 68zuhKQfKPk <[email protected]> Co-authored-by: kPKfQKhuz86 <[email protected]> Co-authored-by: anas-yousef <[email protected]> Co-authored-by: omerKarkKatz <[email protected]> Co-authored-by: Jakob Weinzettl <[email protected]> Co-authored-by: okarkkatz <[email protected]> Co-authored-by: MosheEichler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
Add a parameter that takes in imput base64 to upload binary file to XSOAR.
Base64 encoding is just a way to pass binary as a parameter, the function will decode the base64 and insert the output in the file.
Must have