Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes related to Securonix release 2.0.13 #30340

Conversation

scnx-knathani
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

  • Updated securonix-get-incident and securonix-list-incidents commands to include the Spotter query in the HR and context by upgrading to the latest version of the API.
  • Updated the securonix-list-incidents command to include the Incident ID field in the HR column.
  • Updated the securonix-list-violation-data command, where the query argument now supports the auto inclusion of the "index" with a default value as "violation" if not provided.
  • Updated the Docker image to: demisto/python3:3.10.13.78960.

Must have

  • Tests
  • Documentation

@MosheEichler
Copy link
Contributor

MosheEichler commented Oct 23, 2023

Hi @scnx-knathani,
Thank you for your contribution!
Good work :)
Please feel free to reach out to me with any questions - I'm available here or on slack :)
Thanks again.

@melamedbn
Can you please take a look a the Classifiers changes?

@ShirleyDenkberg
Can you please take a look at the docs?

@ShirleyDenkberg ShirleyDenkberg self-assigned this Oct 23, 2023
Packs/Securonix/ReleaseNotes/2_0_13.md Outdated Show resolved Hide resolved
Packs/Securonix/ReleaseNotes/2_0_13.md Outdated Show resolved Hide resolved
Packs/Securonix/ReleaseNotes/2_0_13.md Outdated Show resolved Hide resolved
Packs/Securonix/ReleaseNotes/2_0_13.md Outdated Show resolved Hide resolved
@ShirleyDenkberg
Copy link
Contributor

@melamedbn @MosheEichler Doc review completed.

@MosheEichler MosheEichler added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Oct 23, 2023
@melamedbn
Copy link
Contributor

Hi @scnx-knathani,

Can you please explain the changes made to the mappers?

Best regards,
Ben

@scnx-knathani
Copy link
Contributor Author

Hi @scnx-knathani,

Can you please explain the changes made to the mappers?

Best regards, Ben

Previously we removed the index=violation from the Spotter query using the transformers in the Mapper but from now onwards this will be handled in the command logic itself we'll show the full query to the end user without trimming the layout hence this change was made in the Mapper. Please let me know if you've further questions on this.

@MosheEichler MosheEichler merged commit e5cc711 into demisto:contrib/scnx-knathani_Securonix-Release-2-0-13 Oct 24, 2023
20 of 22 checks passed
MosheEichler added a commit that referenced this pull request Oct 24, 2023
* Changes related to Securonix release 2.0.13

* Update Packs/Securonix/ReleaseNotes/2_0_13.md



* Update Packs/Securonix/ReleaseNotes/2_0_13.md



* Update 2_0_13.md

---------

Co-authored-by: scnx-knathani <[email protected]>
Co-authored-by: Moshe Eichler <[email protected]>
Co-authored-by: ShirleyDenkberg <[email protected]>
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* Changes related to Securonix release 2.0.13

* Update Packs/Securonix/ReleaseNotes/2_0_13.md



* Update Packs/Securonix/ReleaseNotes/2_0_13.md



* Update 2_0_13.md

---------

Co-authored-by: scnx-knathani <[email protected]>
Co-authored-by: Moshe Eichler <[email protected]>
Co-authored-by: ShirleyDenkberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Security Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants