Complete CyberArk IAM/Secrets Manager Adoption #30257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per CyberArk's request
|
|
kgal-pan
changed the title
omerKarkKatz
requested review from
omerKarkKatz
and removed request for
sapirshuker
kgal-pan
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
@kgal-pan @MMCrosby
Hey, looks good thank you for the contribution and congratulations for the adoption of your pack!
A few notes.
Please bump the version of the pack
In the release notes please write something in the form of:
- Updated the pack from xsoar support to Cyberack partner support.
Also please add to the pack readme file -
Note: Support for this Pack moved to the partner on [MONTH], [DAY], [YEAR].
Please contact the partner directly via the support link on the right. [link or mail]
As mentioned here as part of the adoption process.
Thanks again @omerKarkKatz
kgal-pan
merged commit 539dc40
into
demisto:contrib/MMCrosby_patch-2
18 of 19 checks passed
omerKarkKatz
pushed a commit
that referenced
this pull request
Oct 22, 2023
* Update README.md Per CyberArk's request * modified pack metadata * added author image * update author image * decreased size of author image * added secret ignore * rm conflict patch * revert vectra ai readme * added rn added adoption readme preface --------- Co-authored-by: Melody Crosby <[email protected]> Co-authored-by: Kobbi Gal <[email protected]> Co-authored-by: kgal-pan <[email protected]>
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Update README.md Per CyberArk's request * modified pack metadata * added author image * update author image * decreased size of author image * added secret ignore * rm conflict patch * revert vectra ai readme * added rn added adoption readme preface --------- Co-authored-by: Melody Crosby <[email protected]> Co-authored-by: Kobbi Gal <[email protected]> Co-authored-by: kgal-pan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per CyberArk's request
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Must have