-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Prisma Cloud Compute] Commands Arguments Description Update #30220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comment.
there is one deletion I don't understand, and also I am not sure the original bug and fix expectations are correct.
I written it the ticket.
...pute/Integrations/PaloAltoNetworks_PrismaCloudCompute/PaloAltoNetworks_PrismaCloudCompute.py
Show resolved
Hide resolved
BEAdi
changed the title
[Prisma Cloud Compute] Error to Info
[Prisma Cloud Compute] Commands Arguments Description Update
Oct 26, 2023
yuvalbenshalom
approved these changes
Oct 26, 2023
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
* update descriptions * dockerimage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-8638
Description
Change errors to info in cases where the argument provided doesn't exist.Change hostname argument to required in cases where an error returned if it is not provided. This is a BC, now it will be caught before running the command instead of getting an error after running it.Update command arguments descriptions in order to clarify where hostname argument values should be taken from.
Must have