Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prisma Cloud Compute] Commands Arguments Description Update #30220

Merged
merged 14 commits into from
Oct 26, 2023

Conversation

BEAdi
Copy link
Contributor

@BEAdi BEAdi commented Oct 17, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-8638

Description

Change errors to info in cases where the argument provided doesn't exist.
Change hostname argument to required in cases where an error returned if it is not provided. This is a BC, now it will be caught before running the command instead of getting an error after running it.
Update command arguments descriptions in order to clarify where hostname argument values should be taken from.

Must have

  • Tests
  • Documentation

@BEAdi BEAdi self-assigned this Oct 17, 2023
@BEAdi BEAdi requested a review from GuyAfik as a code owner October 17, 2023 09:56
@BEAdi BEAdi removed the request for review from GuyAfik October 17, 2023 09:56
Copy link
Contributor

@yuvalbenshalom yuvalbenshalom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment.
there is one deletion I don't understand, and also I am not sure the original bug and fix expectations are correct.
I written it the ticket.

@BEAdi BEAdi changed the title [Prisma Cloud Compute] Error to Info [Prisma Cloud Compute] Commands Arguments Description Update Oct 26, 2023
@BEAdi BEAdi merged commit 1940a23 into master Oct 26, 2023
16 checks passed
@BEAdi BEAdi deleted the pcc-error-to-info branch October 26, 2023 17:54
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants