-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Marketplace Contribution] Github Maltrail Feed #30052
Merged
MosheEichler
merged 31 commits into
demisto:contrib/xsoar-contrib_asantamarina-contrib-GithubMaltrailFeed
from
xsoar-contrib:asantamarina-contrib-GithubMaltrailFeed
Nov 5, 2023
Merged
[Marketplace Contribution] Github Maltrail Feed #30052
MosheEichler
merged 31 commits into
demisto:contrib/xsoar-contrib_asantamarina-contrib-GithubMaltrailFeed
from
xsoar-contrib:asantamarina-contrib-GithubMaltrailFeed
Nov 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @asantamarina
Amazing work!!!
Please see my comments
Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py
Outdated
Show resolved
Hide resolved
Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py
Outdated
Show resolved
Hide resolved
Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py
Outdated
Show resolved
Hide resolved
Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py
Outdated
Show resolved
Hide resolved
Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.yml
Outdated
Show resolved
Hide resolved
Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py
Outdated
Show resolved
Hide resolved
Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py
Outdated
Show resolved
Hide resolved
Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py
Outdated
Show resolved
Hide resolved
Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py
Outdated
Show resolved
Hide resolved
Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py
Outdated
Show resolved
Hide resolved
MosheEichler
added
the
pending-contributor
The PR is pending the response of its creator
label
Oct 11, 2023
@MLainer1 Can you please review? |
…bMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]>
…bMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]>
…bMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]>
…bMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]>
…bMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]>
…bMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]>
…bMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]>
…bMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]>
…bMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]>
…bMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]>
…bMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]>
…bMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]>
Hey @asantamarina |
…bMaltrailFeed.yml Co-authored-by: Moshe Eichler <[email protected]>
…bMaltrailFeed.yml Co-authored-by: Moshe Eichler <[email protected]>
…bMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]>
Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.yml
Show resolved
Hide resolved
…bMaltrailFeed.yml
…bMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]>
…bMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]>
…ration-Github_Maltrail_Feed.yml
MosheEichler
approved these changes
Nov 5, 2023
MosheEichler
merged commit Nov 5, 2023
693e390
into
demisto:contrib/xsoar-contrib_asantamarina-contrib-GithubMaltrailFeed
12 of 14 checks passed
MosheEichler
added a commit
that referenced
this pull request
Nov 6, 2023
* [Marketplace Contribution] Github Maltrail Feed (#30052) * "pack contribution initial commit" * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]> * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]> * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]> * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]> * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]> * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]> * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]> * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]> * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]> * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]> * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]> * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]> * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.yml Co-authored-by: Moshe Eichler <[email protected]> * Update GithubMaltrailFeed.yml * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.yml Co-authored-by: Moshe Eichler <[email protected]> * Update GithubMaltrailFeed.py * Update GithubMaltrailFeed.py * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]> * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.yml * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]> * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]> * Delete Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/integration-Github_Maltrail_Feed.yml * Update pack_metadata.json * Update GithubMaltrailFeed.yml * Update GithubMaltrailFeed.py * Update GithubMaltrailFeed.py * Update GithubMaltrailFeed.yml * Update GithubMaltrailFeed.py * Update GithubMaltrailFeed.yml * Update GithubMaltrailFeed.py --------- Co-authored-by: Abel S. Santamarina <[email protected]> Co-authored-by: Moshe Eichler <[email protected]> * pre-commit fixes * add README.md * fix json * format * from version * categories * validate fixes * remove f string --------- Co-authored-by: xsoar-bot <[email protected]> Co-authored-by: Abel S. Santamarina <[email protected]> Co-authored-by: Moshe Eichler <[email protected]> Co-authored-by: MosheEichler <[email protected]>
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
* [Marketplace Contribution] Github Maltrail Feed (#30052) * "pack contribution initial commit" * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]> * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]> * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]> * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]> * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]> * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]> * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]> * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]> * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]> * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]> * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]> * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]> * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.yml Co-authored-by: Moshe Eichler <[email protected]> * Update GithubMaltrailFeed.yml * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.yml Co-authored-by: Moshe Eichler <[email protected]> * Update GithubMaltrailFeed.py * Update GithubMaltrailFeed.py * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]> * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.yml * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]> * Update Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/GithubMaltrailFeed.py Co-authored-by: Moshe Eichler <[email protected]> * Delete Packs/GithubMaltrailFeed/Integrations/GithubMaltrailFeed/integration-Github_Maltrail_Feed.yml * Update pack_metadata.json * Update GithubMaltrailFeed.yml * Update GithubMaltrailFeed.py * Update GithubMaltrailFeed.py * Update GithubMaltrailFeed.yml * Update GithubMaltrailFeed.py * Update GithubMaltrailFeed.yml * Update GithubMaltrailFeed.py --------- Co-authored-by: Abel S. Santamarina <[email protected]> Co-authored-by: Moshe Eichler <[email protected]> * pre-commit fixes * add README.md * fix json * format * from version * categories * validate fixes * remove f string --------- Co-authored-by: xsoar-bot <[email protected]> Co-authored-by: Abel S. Santamarina <[email protected]> Co-authored-by: Moshe Eichler <[email protected]> Co-authored-by: MosheEichler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Community Support Level
Indicates that the contribution is for Community supported pack
Contribution
Thank you! Contributions are always welcome!
External PR
pending-contributor
The PR is pending the response of its creator
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Contributor
@asantamarina
Description
Maltrail is a malicious traffic detection system, utilizing publicly available (black)lists containing malicious and/or generally suspicious trails, along with static trails compiled from various AV reports and custom user defined lists, where trail can be anything from domain name (e.g. zvpprsensinaix.com for Banjori malware), URL (e.g. hXXp://109.162.38.120/harsh02.exe for known malicious executable), IP address (e.g. 185.130.5.231 for known attacker) or HTTP User-Agent header value (e.g. sqlmap for automatic SQL injection and database takeover tool). Also, it uses (optional) advanced heuristic mechanisms that can help in discovery of unknown threats (e.g. new malware).
https://github.com/stamparm/maltrail
Video Link
Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.