Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test connection MicrosoftGraphMail #27033

Merged
merged 5 commits into from
May 29, 2023

Conversation

rshunim
Copy link
Contributor

@rshunim rshunim commented May 29, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue https://jira-hq.paloaltonetworks.local/browse/XSUP-24709

Description

Changing the api call in the test connection to mail-list-emails with limit 1 (since the current api call requires more permissions).
In addition, adding to the documentation (in o365) the 'Required Permissions'.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@rshunim rshunim requested a review from michal-dagan May 29, 2023 07:42
@rshunim rshunim self-assigned this May 29, 2023
@rshunim rshunim requested a review from yucohen May 29, 2023 12:05
@rshunim rshunim changed the title Fix test func MicrosoftGraphMail Fix test connection MicrosoftGraphMail May 29, 2023
Copy link
Contributor

@yucohen yucohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@rshunim rshunim merged commit d5c128e into master May 29, 2023
@rshunim rshunim deleted the fix_broken_test_func_Microsoft_Graph_Mail branch May 29, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants