Skip to content

Commit

Permalink
complete removal of all remaining rmp functionality including simply …
Browse files Browse the repository at this point in the history
…providing links to rmp
  • Loading branch information
demetrios-koziris committed Dec 16, 2016
1 parent eedd30f commit 93f3412
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 13 deletions.
5 changes: 2 additions & 3 deletions src/js/addProfLinks.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ function makeProfLinks() {
let profsFullSource = document.getElementsByClassName("catalog-instructors")[0].innerHTML;

const loadMessage = "McGill Enhanced is loading ratings!";
const rmpMessage = "McGill Enhanced is no longer allowed to display RMP ratings here.<br>In order to find and view professor ratings, please click to visit RMP.";
const rmpMessage = "McGill Enhanced is no longer<br>able to integrate with RMP.";


if (!profsFullSource.match(/There are no professors/)) {
Expand All @@ -48,8 +48,7 @@ function makeProfLinks() {

let profName = generateProfNameObject(profsByTerm[termKey][p]);
profs[profName.fullNameKey] = profName;
newProfsHTML += "<a href='http://www.ratemyprofessors.com/search.jsp?query=mcgill " + profName.firstName + " " + profName.lastName;
newProfsHTML += " ' class=\"tooltip " + profName.fullNameKey + "\" title=\"" + rmpMessage + "\" rel=\"noopener noreferrer\">" + profName.fullName + "</a>";
newProfsHTML += "<span class=\"tooltip " + profName.fullNameKey + "\" title=\"" + rmpMessage + "\">" + profName.fullName + "</span>";
if (p <= profsByTerm[termKey].length-2) {
newProfsHTML += ", ";
}
Expand Down
5 changes: 1 addition & 4 deletions src/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,12 @@
"name": "McGill Enhanced",
"author": "Demetrios Koziris",
"manifest_version": 2,
"version": "3.0.2",
"version": "3.0.3",
"description": "Enhance the functionality of McGill.ca",
"permissions" : [
"declarativeContent",
"*://www.mcgill.ca/study/*",
"*://horizon.mcgill.ca/*",
"*://www.ratemyprofessors.com/search*",
"*://www.docuum.com/McGill*",
"*://vsb.mcgill.ca/*"
],
Expand All @@ -33,7 +32,6 @@
"matches" : [
"*://www.mcgill.ca/study/*",
"*://horizon.mcgill.ca/*",
"*://www.ratemyprofessors.com/search*",
"*://www.docuum.com/McGill*",
"*://vsb.mcgill.ca/*"
],
Expand All @@ -56,7 +54,6 @@
"matches" : [
"*://www.mcgill.ca/study/*",
"*://horizon.mcgill.ca/*",
"*://www.ratemyprofessors.com/search*",
"*://www.docuum.com/McGill*",
"*://vsb.mcgill.ca/*"
],
Expand Down
3 changes: 0 additions & 3 deletions src/menu/quicklinksMenu.css
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,6 @@
.mcgillButton:hover {
background: -webkit-linear-gradient(left, #E54944, #C5C5C5);
}
.rmpButton:hover {
background: -webkit-linear-gradient(left, #B2CF36, #C5C5C5);
}
.amazonButton:hover {
background: -webkit-linear-gradient(left, #F8991D, #C5C5C5);
}
3 changes: 0 additions & 3 deletions src/menu/quicklinksMenu.html
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,6 @@ <h4 class="meTitle">
<a href="http://www.docuum.com/McGill" target="_blank" rel="noopener noreferrer" class="btn btn-default meButton docuumButton">
Docuum
</a>
<a href="http://www.ratemyprofessors.com/campusRatings.jsp?sid=1439" target="_blank" rel="noopener noreferrer" class="btn btn-default meButton rmpButton">
RateMyProfessors
</a>
<a href="https://demetrios-koziris.github.io/McGillEnhanced/" target="_blank" rel="noopener noreferrer" class="btn btn-default meButton mcgillButton">
McGill Enhanced Site
</a>
Expand Down

0 comments on commit 93f3412

Please sign in to comment.