Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the coveralls badge being cached #104

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

jalextowle
Copy link
Contributor

Despite the kill-cache query parameter, the badge still doesn't update on main. Referring to this issue, it seems that adding &service=github will fix the issue. Anecdotally, it fixed the issue as I'm now seeing that we have 66% coverage.

@coveralls
Copy link
Collaborator

coveralls commented Feb 23, 2023

Pull Request Test Coverage Report for Build 4254579669

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.071%

Totals Coverage Status
Change from base Build 4250491362: 0.0%
Covered Lines: 370
Relevant Lines: 560

💛 - Coveralls

@jalextowle jalextowle requested a review from jrhea February 23, 2023 16:13
@jalextowle jalextowle force-pushed the jalextowle/docs/coveralls-badge-caching branch from cbcc974 to 28505a3 Compare February 23, 2023 16:13
@jalextowle jalextowle merged commit 2071662 into main Feb 23, 2023
@jalextowle jalextowle deleted the jalextowle/docs/coveralls-badge-caching branch February 23, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants