Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-organize lp.rs into directory. #106

Merged
merged 1 commit into from
May 18, 2024

Conversation

sentilesdal
Copy link
Contributor

@sentilesdal sentilesdal commented May 17, 2024

Description

Re-organizes lp.rs into a directory structure to match long and short.

Before:

lp.rs // has everything

After:


lp.rs			// just module exports
lp/
  add.rs		// add functionality of HyperdriveLP.sol
  remove.rs		// remove functionality of HyperdriveLP.sol
  math.rs		// LPMath.sol

base.rs			// HyperdriveBase.sol

Review Checklists

Please check each item before approving the pull request. While going
through the checklist, it is recommended to leave comments on items that are
referenced in the checklist to make sure that they are reviewed.

  • Testing
    • Are there new or updated unit or integration tests?
    • Do the tests cover the happy paths?
    • Do the tests cover the unhappy paths?
    • Are there an adequate number of fuzz tests to ensure that we are
      covering the full input space?
    • If matching Solidity behavior, are there differential fuzz tests that
      ensure that Rust matches Solidity?

Copy link
Member

@ryangoree ryangoree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 🚀

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

placeholder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, to be filled in shortly

@sentilesdal sentilesdal force-pushed the matt/reorganize-hyperdrive-math-lp branch 4 times, most recently from 5620030 to f2a2137 Compare May 18, 2024 03:15
@sentilesdal sentilesdal force-pushed the matt/reorganize-hyperdrive-math-lp branch from f2a2137 to 42ba8ad Compare May 18, 2024 03:28
@sentilesdal sentilesdal merged commit b410d21 into main May 18, 2024
7 of 8 checks passed
@sentilesdal sentilesdal deleted the matt/reorganize-hyperdrive-math-lp branch May 18, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants