feat: Initial approach to support nexus integration #235
Conversation
contracts/external/nexus/interfaces/IWrappedFuturesPrincipal.sol
Outdated
Show resolved
Hide resolved
contracts/external/nexus/interfaces/IWrappedFuturesPrincipal.sol
Outdated
Show resolved
Hide resolved
contracts/external/nexus/WrappedCoveredPrincipalTokenFactory.sol
Outdated
Show resolved
Hide resolved
| IERC20(_tranche).safeTransferFrom( | ||
| msg.sender, | ||
| address(this), | ||
| _fromWad(_amount, _tranche) |
There was a problem hiding this comment.
This conversion unnecessary because the constructor of the tranche locks the decimals of the tranche to be equal to that of underlying.
There was a problem hiding this comment.
I think it is needed as there is a chance where tranche and wrapped covered principal token have different decimals.
There was a problem hiding this comment.
Why is that possible? Perhaps we should set to match the underlying as well.
There was a problem hiding this comment.
Then I think we can only match it with the baseToken decimals. Although I am agnostic for this change.
There was a problem hiding this comment.
I think we should match it with the base decimal tokens 100% of the time.
| /// @notice Reclaim tranche token (i.e principal token) by the authorized account. | ||
| /// @param _expiration Timestamp at which the derived tranche would get expired. | ||
| /// @param _wrappedPosition Address of the Wrapped position which is used to derive the tranche. | ||
| function reclaimPt(uint256 _expiration, address _wrappedPosition) |
There was a problem hiding this comment.
I think this function should burn sender's balance and send them the corresponding amount of underlying. As it stands, the RECLAIM_ROLE can just rug the whole underlying at any moment.
I expect RECLAIM_ROLE to be given to a third party like Nexus mutual so I don't want this trust in the system.
There was a problem hiding this comment.
I don't think this makes sense. The wrapping is a one way function so you can't really 'rug' the backing token because a wrappers can't get any funds out anyway. Also we don't want to require Nexus to have the tokens because we want to give them max flexibility to redeem even if their architecture means a sc without generic call holds the tokens.
There was a problem hiding this comment.
The wrapping is a one way function so you can't really 'rug' the backing token because a wrappers can't get any funds out anyway.
This function sends the tranche tokens to the user. aka it is unwrapping the wrapped tokens without consuming the wrapped tokens.
Also we don't want to require Nexus to have the tokens because we want to give them max flexibility to redeem even if their architecture means a sc without generic call holds the tokens.
If we are ok with this trust in the system, this comment can be ignored.
Note - I used very layman terminology in the code to make it more understandable although the code is very straightforward. Open for the naming convention change 😜