Add Compound Asset Proxy #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleph-v
reviewed
Nov 9, 2021
satyamakgec
suggested changes
Dec 10, 2021
contracts/test/TestCAssetProxy.sol
Outdated
| import "../WrappedPosition.sol"; | ||
| import "./TestCToken.sol"; | ||
|
|
||
| contract TestCAssetProxy is WrappedPosition { |
There was a problem hiding this comment.
instead of copy-pasting the whole code can't we inherit the main code and make the function virtual to override as we want. It will be more cleaner approach
smmackey
force-pushed
the
smmackey/compound-asset-proxy
branch
3 times, most recently
from
f12e7c2 to
3611058
Compare
satyamakgec
approved these changes
Jan 20, 2022
smmackey
force-pushed
the
smmackey/compound-asset-proxy
branch
from
d9541a1 to
a58479d
Compare
|
Task linked: PD-29 Compound Asset Proxy |
|
Task linked: PD-110 Contract implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.