Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add QUERY to httpMethods which was added in Node 22.2.0 #380

Merged
merged 2 commits into from
Sep 28, 2024
Merged

fix: add QUERY to httpMethods which was added in Node 22.2.0 #380

merged 2 commits into from
Sep 28, 2024
+4 −4

Conversation

andokai
Copy link
Contributor

@andokai andokai commented Sep 24, 2024

fixes #379

mcollina
mcollina approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andokai
test: update pretty-print.test.js
674900a 
Add QUERY to list of methods in test
@mcollina mcollina merged commit c38bd87 into delvedor:main Sep 28, 2024
7 checks passed
@andokai andokai mentioned this pull request Oct 25, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-tymoshenko ivan-tymoshenko ivan-tymoshenko approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

httpMethods is a snapshot from Node 18.12.0 meaning methods from newer versions are unsupported
3 participants
@andokai @mcollina @ivan-tymoshenko