Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable versioning on demand #172

Merged
merged 4 commits into from
Nov 6, 2020
Merged

Enable versioning on demand #172

merged 4 commits into from
Nov 6, 2020

Conversation

delvedor
Copy link
Owner

@delvedor delvedor commented Nov 6, 2020

This pull request disables the automatic route versioning unless a user has configured at least once a route with the version option.

@delvedor delvedor added the bugfix label Nov 6, 2020
@delvedor delvedor requested a review from mcollina November 6, 2020 17:24
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@delvedor delvedor merged commit ab40835 into master Nov 6, 2020
@delvedor delvedor deleted the enable-versioning-on-demand branch November 6, 2020 17:30
delvedor added a commit that referenced this pull request Nov 6, 2020
@airhorns
Copy link
Contributor

airhorns commented Nov 7, 2020

Could you maybe add a little more context as to why this was necessary? I think the constraints implementation has to change to support this but I can't really tell how.

@airhorns
Copy link
Contributor

ping @mcollina @delvedor would love to know why this change was necessary

@mcollina
Copy link
Collaborator

It's a security vulnerability, see https://snyk.io/vuln/SNYK-JS-FINDMYWAY-1038269 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants