Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning (#2227) #2230

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Fix warning (#2227) #2230

merged 1 commit into from
Jul 9, 2024

Conversation

zeitschlag
Copy link
Collaborator

@zeitschlag zeitschlag commented Jul 6, 2024 •
edited
Loading

Took me a little to figure this out.
What didn't work:

  • Rewriting ChatTitleView without computed properties
  • Different ways for spacing

Fixes #2227.

@zeitschlag zeitschlag requested a review from r10s July 6, 2024 12:08
r10s
r10s approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks reasonable somehow.

testing this on a real device, things look good up to now as well :)

@zeitschlag zeitschlag merged commit 7810a34 into main Jul 9, 2024
1 check passed
@zeitschlag zeitschlag deleted the 2227-titleview-constraints branch July 9, 2024 12:09
@zeitschlag zeitschlag added this to the 1.46.8 milestone Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r10s r10s r10s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.46.8
Development

Successfully merging this pull request may close these issues.

Unable to simultaneously satisfy constraints when opening message view
2 participants
@zeitschlag @r10s