Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

share contacts from "contact profile" #2273

Closed
r10s opened this issue Aug 20, 2024 · 2 comments · Fixed by #2292
Closed

share contacts from "contact profile" #2273

r10s opened this issue Aug 20, 2024 · 2 comments · Fixed by #2292
Assignees
@zeitschlag
Labels
enhancement actually in development, user visible enhancement
Milestone
1.46.10

Comments

@r10s
Copy link
Member

r10s commented Aug 20, 2024

add a share button beside "search" and "mute" or below "send message".

"sharing" here means to select a chat and to stage the vcard

compare deltachat/deltachat-android#3170
@r10s r10s added the enhancement actually in development, user visible enhancement label Aug 20, 2024
@zeitschlag zeitschlag self-assigned this Aug 28, 2024
zeitschlag added a commit that referenced this issue Aug 29, 2024
@zeitschlag
Add entry to share contact (#2273)
527865c
@zeitschlag zeitschlag mentioned this issue Aug 29, 2024
Merged
@zeitschlag
Copy link
Collaborator

zeitschlag commented Aug 29, 2024 •
edited
Loading

2273

Decided to go with an additional cell here as a third button would heavily truncate the email address. Still not soooo happy how that cell looks, it's a bit lost.

zeitschlag added a commit that referenced this issue Aug 29, 2024
@zeitschlag
Make RelayHelper vcard-capable (#2273)
e83f716
zeitschlag added a commit that referenced this issue Aug 29, 2024
@zeitschlag
Forward contact (#2273)
c886a19
@r10s
Copy link
Member Author

r10s commented Aug 29, 2024

maybe move the cell to the section above, directly below "Send Message"? greetings from 🇸🇪

zeitschlag added a commit that referenced this issue Aug 29, 2024
@zeitschlag
Show "Share" not in own section (#2273)
f8e3191
zeitschlag added a commit that referenced this issue Aug 29, 2024
@zeitschlag
Don't show share for device-talk and notes to self (#2273)
97b4f37 
Sharing these contacts doesn't make a lot of sense.
@zeitschlag zeitschlag added this to the Next Release milestone Aug 29, 2024
zeitschlag added a commit that referenced this issue Aug 29, 2024
@zeitschlag
Add entry to share contact (#2273)
92bd92b
zeitschlag added a commit that referenced this issue Aug 29, 2024
@zeitschlag
Make RelayHelper vcard-capable (#2273)
bd00199
zeitschlag added a commit that referenced this issue Aug 29, 2024
@zeitschlag
Forward contact (#2273)
5a671f9
zeitschlag added a commit that referenced this issue Aug 29, 2024
@zeitschlag
Show "Share" not in own section (#2273)
5cc94dc
zeitschlag added a commit that referenced this issue Aug 29, 2024
@zeitschlag
Don't show share for device-talk and notes to self (#2273)
cc009d5 
Sharing these contacts doesn't make a lot of sense.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeitschlag zeitschlag

Labels
enhancement actually in development, user visible enhancement
Projects
onboard friends
Status: Done
Milestone
1.46.10
Development

Successfully merging a pull request may close this issue.

Share contact (#2273) deltachat/deltachat-ios
2 participants
@zeitschlag @r10s