Check text exists before accessing it #4395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
reviewed
Dec 8, 2024
| nonInteractiveContent | ||
| /> | ||
| </div> | ||
| {hasMessage && quote.text && ( |
There was a problem hiding this comment.
Doesn't this hide the quote when quote.kind === 'JustText'? Because hasMessage is defined as quote.kind === 'WithMessage'.
And I think we need a comment for the quote.text && check, at least link the issue.
There was a problem hiding this comment.
So now I check only for the text property to exist.
And I think we need a comment for the quote.text && check, at least link the issue
I think it is self explaining to check for the text property to exist before calling "slice" on it.
There was a problem hiding this comment.
Well, the thing is that the types say that it always exists.
WofWca
approved these changes
Dec 8, 2024
| nonInteractiveContent | ||
| /> | ||
| </div> | ||
| {quote.text && ( |
There was a problem hiding this comment.
Suggested change
| {quote.text && ( | |
| {/* `quote.text` might be `undefined` due to | |
| https://github.com/deltachat/deltachat-desktop/issues/4337#issuecomment-2473521298 */} | |
| {quote.text && ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4337