Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: hide reactions instead of wrapping #4176

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

WofWca
Copy link
Collaborator

@WofWca WofWca commented Oct 5, 2024

on narrower screens.

Closes #4322

Before:

image

After:

reactions-wrap-hide.mp4

@WofWca WofWca force-pushed the wofwca/fix-reaction-wrapping branch from 9a07f69 to 67a4dc2 Compare October 5, 2024 14:15
@WofWca WofWca marked this pull request as ready for review October 5, 2024 14:18
@WofWca WofWca requested a review from adbenitez October 5, 2024 14:18
@WofWca WofWca added bug Something isn't working ui/ux UI/UX related issues labels Oct 5, 2024
@Simon-Laux
Copy link
Member

I think SHOW_MAX_DIFFERENT_EMOJIS should be dynamic -> if there is not enough space for all emojis show only the ones that fit and the more button.

@WofWca WofWca marked this pull request as draft October 6, 2024 12:42
@adbenitez
Copy link
Member

yes, so user can realize there are more reactions similar to what happens in android that you get a (+N) pill with the number of other reactions that are not displayed

@nicodh
Copy link
Contributor

nicodh commented Nov 8, 2024

resolves #4322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui/ux UI/UX related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide reactions instead of wrapping
4 participants