-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cargo): upgrade iroh to 0.27.0 #6133
Conversation
I just successfully upgraded to 0.26.0 in #6132. But iroh 0.27.0 fails all tests in CI. |
Debug logs:
I will bisect to the iroh commit that broke it. Can also try with a newer relay, but don't see why it should not work with older relay especially if no network compatibility breaking changes are in the release notes. iroh-relay running on iroh.tesrun.org is 0.25.0. |
I have bisected the problem to commit n0-computer/iroh@5e40fe1 git-bisect log: |
And the following patch fixes the problem, so it is indeed this commit that broke it:
|
And now on a different connection it runs. Fails in GitHub Actions, on mobile hotspot connected to LTE and on one of the Wi-Fi networks, but works on another Wi-Fi network. |
On a failing connection:
On a successful connection:
So basically iroh now works only on a connection with working UPNP. |
On a network without UPNP running |
Downgraded igd-next to 0.15.0, still fails. So the problem appeared somewhere between 0.14.3 and 0.15.0, and the only change was dariusc93/rust-igd#8 (commit dariusc93/rust-igd@56934bb) not counting dariusc93/rust-igd@a06b503 |
With
|
If I short-circuit |
@link2xt the commit you linked dariusc93/rust-igd@56934bb at a minimum makes igd-next not respect the timeouts we set for it, however if I replace all port-mapping code with a long sleep, things still work, which is very confusing. Can you describe what the scenario and test does so that I can try to reproduce? Even with the replaced code, for example, a |
Scenario I am testing is deltachat-core-rust/deltachat-rpc-client/tests/test_iroh_webxdc.py Lines 79 to 120 in 88278fc
It is two iroh nodes joining a single gossip topic and then sending a message. |
Maybe try to replace I don't get why |
@divagant-martian I managed to reproduce it with just
(STUN port copy-pasted from https://www.iroh.computer/docs/reference/config, only changed the URL) Then run inside
On a network without UPNP:
|
I have created an issue in iroh repo: n0-computer/iroh#2876 |
Let's close this for now and upgrade to a version that has the problem fixed once n0-computer/iroh#2876 is closed. |
No description provided.