[Kernel] Add JsonMetadataDomain and RowTrackingMetadataDomain #3893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Errors.java Co-authored-by: Johan Lasperas <[email protected]>
Co-authored-by: Johan Lasperas <[email protected]>
Co-authored-by: Johan Lasperas <[email protected]>
…uring conflict resolution
…actDomainMetadataMap to fillDomainMetadataMap.
qiyuandong-db
force-pushed
the
delta-kernel-JsonMetadataDomain
branch
from
9f46828
to
b32c56a
Compare
johanl-db
reviewed
Nov 21, 2024
Comment on lines
+49
to
+50
| /** Default value for row ID high watermark when it is missing in the table */ | ||
| public static final long MISSING_ROW_ID_HIGH_WATERMARK = -1L; |
There was a problem hiding this comment.
This isn't used, add it in the following change for populating row ids
Comment on lines
+27
to
+45
| /** | ||
| * Creates an instance of {@link RowTrackingMetadataDomain} from a JSON configuration string. | ||
| * | ||
| * @param json the JSON configuration string | ||
| * @return an instance of {@link RowTrackingMetadataDomain} | ||
| */ | ||
| public static RowTrackingMetadataDomain fromJsonConfiguration(String json) { | ||
| return JsonMetadataDomain.fromJsonConfiguration(json, RowTrackingMetadataDomain.class); | ||
| } | ||
|
|
||
| /** | ||
| * Creates an instance of {@link RowTrackingMetadataDomain} from a {@link SnapshotImpl}. | ||
| * | ||
| * @param snapshot the snapshot instance | ||
| * @return an {@link Optional} containing the {@link RowTrackingMetadataDomain} if present | ||
| */ | ||
| public static Optional<RowTrackingMetadataDomain> fromSnapshot(SnapshotImpl snapshot) { | ||
| return JsonMetadataDomain.fromSnapshot(snapshot, RowTrackingMetadataDomain.class, DOMAIN_NAME); | ||
| } |
There was a problem hiding this comment.
Move these either below the constructor or at the end of the class
| * RowTrackingMetadataDomain}, should extend this class to define a specific metadata domain. | ||
| */ | ||
| public abstract class JsonMetadataDomain { | ||
| private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper(); |
There was a problem hiding this comment.
It would be good to review the default configuration used for serializing/deserializing.
E.g. does it correctly fail if the json string has missing fields / extra fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
This PR builds on the base changes for introducing DomainMetadata into the Kernel, which are not yet merged. For changes specific to this PR, please refer to the last commit only.
This PR adds the following to Delta Kernel Java:
JsonMetadataDomain.java: Introduces the base abstract classJsonMetadataDomainfor metadata domains that use JSON as their configuration string. Concrete implementations, such asRowTrackingMetadataDomain, should extend this class to define their specific metadata domain behavior. This class providesDomainMetadataaction for committingRowTrackingMetadataDomain.java: Implements the metadata domaindelta.rowTracking. It manages row ID high water mark, which will be used in the future for assigning fresh row IDs.How was this patch tested?
Added tests covering the functionalities of
JsonMetadataDomainandRowTrackingMetadataDomaininDomainMetadataSuite.scala.Does this PR introduce any user-facing changes?
No.