[Kernel][Parquet Writer] Fix an issue with writing decimal as binary #3233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
allisonport-db
approved these changes
Jun 7, 2024
vkorukanti
added a commit
to vkorukanti/delta
that referenced
this pull request
Jun 7, 2024
…elta-io#3233) ## Description The number of bytes needed to calculate the max buffer size needed when writing the decimal type to Parquet is off by one. Resolved delta-io#3152 ## How was this patch tested? Added unit tests that read and write decimals with various precision and scales.
vkorukanti
added a commit
to vkorukanti/delta
that referenced
this pull request
Aug 30, 2024
…elta-io#3233) ## Description The number of bytes needed to calculate the max buffer size needed when writing the decimal type to Parquet is off by one. Resolved delta-io#3152 ## How was this patch tested? Added unit tests that read and write decimals with various precision and scales.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The number of bytes needed to calculate the max buffer size needed when writing the decimal type to Parquet is off by one.
Resolved #3152
How was this patch tested?
Added unit tests that read and write decimals with various precision and scales.