Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kernel] Remove unused ExpressionHandler.isSupported(...) for now #3018

Merged
merged 2 commits into from
May 3, 2024

Conversation

allisonport-db
Copy link
Collaborator

@allisonport-db allisonport-db commented May 2, 2024

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Description

Removes a currently unused API in ExpressionHandler.

See #3017 for details. TLDR we added this API before achieving consensus on what we want to implement and it is currently unused. Remove it for now and we can add it back later if needed.

How was this patch tested?

N/A

Does this PR introduce any user-facing changes?

No

@allisonport-db allisonport-db merged commit e7cafec into delta-io:master May 3, 2024
10 checks passed
allisonport-db added a commit to allisonport-db/delta that referenced this pull request May 4, 2024
…elta-io#3018)

<!--
Thanks for sending a pull request!  Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://github.com/delta-io/delta/blob/master/CONTRIBUTING.md
2. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]
Your PR title ...'.
  3. Be sure to keep the PR description updated to reflect all changes.
  4. Please write your PR title to summarize what this PR proposes.
5. If possible, provide a concise example to reproduce the issue for a
faster review.
6. If applicable, include the corresponding issue number in the PR title
and link it in the body.
-->

#### Which Delta project/connector is this regarding?
<!--
Please add the component selected below to the beginning of the pull
request title
For example: [Spark] Title of my pull request
-->

- [ ] Spark
- [ ] Standalone
- [ ] Flink
- [X] Kernel
- [ ] Other (fill in here)

## Description

Removes a currently unused API in `ExpressionHandler`.

See delta-io#3017 for details. **TLDR**
we added this API before achieving consensus on what we want to
implement and it is currently unused. Remove it for now and we can add
it back later if needed.

## How was this patch tested?

N/A

## Does this PR introduce _any_ user-facing changes?

No

(cherry picked from commit e7cafec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants