[#868] Register VACUUM operation in the _delta_log #1552
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update VacuumCommand.scala to add pre-post vacuum logs - update DeltaOperations.scala to add the actual operations committed to the log - update DeltaVacuumSuite with tests
YannByron
reviewed
Jan 10, 2023
core/src/main/scala/org/apache/spark/sql/delta/DeltaOperations.scala
Outdated
Show resolved
Hide resolved
YannByron
reviewed
Jan 10, 2023
core/src/main/scala/org/apache/spark/sql/delta/DeltaOperations.scala
Outdated
Show resolved
Hide resolved
YannByron
reviewed
Jan 10, 2023
core/src/main/scala/org/apache/spark/sql/delta/sources/DeltaSQLConf.scala
Show resolved
Hide resolved
YannByron
reviewed
Jan 10, 2023
core/src/main/scala/org/apache/spark/sql/delta/commands/VacuumCommand.scala
Show resolved
Hide resolved
YannByron
reviewed
Jan 10, 2023
core/src/main/scala/org/apache/spark/sql/delta/commands/VacuumCommand.scala
Show resolved
Hide resolved
YannByron
reviewed
Jan 10, 2023
core/src/main/scala/org/apache/spark/sql/delta/commands/VacuumCommand.scala
Show resolved
Hide resolved
YannByron
reviewed
Jan 10, 2023
| * @param specifiedRetentionMillis - specified retention interval | ||
| * @param defaultRetentionMillis - default retention period for the table | ||
| */ | ||
| case class VacuumStart( |
There was a problem hiding this comment.
Can we combine VacuumStart and Vacuum to one? I think this is enough.
There was a problem hiding this comment.
Do you mean VacuumStart and VacuumEnd? It's better to have two events so that people can quickly check whether the vacuum command completes or not.
YannByron
reviewed
Jan 10, 2023
| @@ -289,6 +292,42 @@ object VacuumCommand extends VacuumCommandImpl with Serializable { | |||
|
|
|||
| trait VacuumCommandImpl extends DeltaCommand { | |||
|
|
|||
| private val supportedFsForLogging = Seq( | |||
| "wasbs", "wasbss", "abfs", "abfss", "adl", "gs", "file" | |||
There was a problem hiding this comment.
I have a question: what is the relationship between whether log vacuum and the file system used?
There was a problem hiding this comment.
+1 to make this a config. The list is also missing hdfs.
Before this change, vacuum doesn't make a commit, so people can run vacuum concurrently with any other queries. After this change, this could be dangerous, for example on S3, if people still run vacuum concurrently with any other queries without using a right LogStore. Hence, we don't enable it by default.
|
Hi @YannByron can you please provide me with your github email address so I can include you as a co-author here? Thanks for making the initial PR (inspiration for this PR) and for reviewing this PR! |
zsxwing
approved these changes
Jan 11, 2023
|
@scottsand-db thank you and i will send you by Slack. |
scottsand-db
added a commit
to scottsand-db/delta
that referenced
this pull request
Jan 12, 2023
This PR registers the start and end of VACUUM operations in the delta log. This means that we commit a commit with no Add/Remove files, and only a `CommitInfo` file which contains the delta operation info. `VacuumStart` operation contains metrics: `numFilesToDelete` and `sizeOfDataToDelete` `VacuumEnd` operation contains metrics: `numDeletedFiles` and `numVacuumedDirectories` New UTs. Expose additional metrics and history in the _delta_log for the start and end of VACUUM operations. Closes delta-io#1552. Resolves delta-io#868. Co-authored-by: Yann Byron <[email protected]> GitOrigin-RevId: 94805531d022bac4afafd0b672d17b8828d8aa2c
scottsand-db
added a commit
to scottsand-db/delta
that referenced
this pull request
Jan 12, 2023
This PR registers the start and end of VACUUM operations in the delta log. This means that we commit a commit with no Add/Remove files, and only a `CommitInfo` file which contains the delta operation info. `VacuumStart` operation contains metrics: `numFilesToDelete` and `sizeOfDataToDelete` `VacuumEnd` operation contains metrics: `numDeletedFiles` and `numVacuumedDirectories` New UTs. Expose additional metrics and history in the _delta_log for the start and end of VACUUM operations. Closes delta-io#1552. Resolves delta-io#868. Co-authored-by: Yann Byron <[email protected]> GitOrigin-RevId: 94805531d022bac4afafd0b672d17b8828d8aa2c
scottsand-db
added a commit
that referenced
this pull request
Jan 13, 2023
This PR registers the start and end of VACUUM operations in the delta log. This means that we commit a commit with no Add/Remove files, and only a `CommitInfo` file which contains the delta operation info. `VacuumStart` operation contains metrics: `numFilesToDelete` and `sizeOfDataToDelete` `VacuumEnd` operation contains metrics: `numDeletedFiles` and `numVacuumedDirectories` New UTs. Expose additional metrics and history in the _delta_log for the start and end of VACUUM operations. Closes #1552. Resolves #868. Co-authored-by: Yann Byron <[email protected]> GitOrigin-RevId: 94805531d022bac4afafd0b672d17b8828d8aa2c
8 tasks
This was referenced Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR registers the start and end of VACUUM operations in the delta log. This means that we commit a commit with no Add/Remove files, and only a
CommitInfofile which contains the delta operation info.VacuumStartoperation contains metrics:numFilesToDeleteandsizeOfDataToDeleteVacuumEndoperation contains metrics:numDeletedFilesandnumVacuumedDirectoriesCloses #868.
How was this patch tested?
New UTs.
Does this PR introduce any user-facing changes?
Expose additional metrics and history in the _delta_log for the start and end of VACUUM operations.