Add the support of the AWS_PROFILE environment variable for S3 #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvaleye
added
enhancement
fvaleye
requested review from
houqp,
xianwill,
wjones127,
roeap,
rtyler and
mosyp
as code owners
|
Waiting for |
rtyler
previously approved these changes
Dec 4, 2022
fvaleye
force-pushed
the
feature/add-aws-profile-support
branch
from
7c3fb15
to
440b136
Compare
fvaleye
force-pushed
the
feature/add-aws-profile-support
branch
4 times, most recently
from
7a01446
to
03b7b3a
Compare
fvaleye
force-pushed
the
feature/add-aws-profile-support
branch
from
03b7b3a
to
f04e0b9
Compare
wjones127
previously approved these changes
Dec 7, 2022
fvaleye
force-pushed
the
feature/add-aws-profile-support
branch
from
c47d57c
to
09e7b0a
Compare
wjones127
approved these changes
Dec 9, 2022
|
This works but is missing from the doc: https://docs.rs/object_store/latest/object_store/aws/enum.AmazonS3ConfigKey.html#variants |
|
This has actually been removed in version 0.6, if you look at the 0.5.6 docs, it should still be there. We need to look into how we continue support for aws profile once we update. |
Yoy! Thanks for the info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AWS_PROFILEenvironment variable for AWS S3object_storeto0.5.2Related Issue(s)
object_store0.5.2(next release after0.5.1) apache/arrow-rs#3229