fix: Address clippy lint warnings. #742
Conversation
rust/src/vacuum.rs
Outdated
| @@ -236,7 +236,8 @@ impl Vacuum { | |||
| }); | |||
| } | |||
|
|
|||
| return plan.execute(table).await; | |||
| //return plan.execute(table).await; | |||
There was a problem hiding this comment.
looks like this should be deleted
| @@ -1,4 +1,5 @@ | |||
| #![deny(warnings)] | |||
| #![allow(clippy::borrow_deref_ref)] | |||
There was a problem hiding this comment.
curious which line is violating this error? we should probably fix that instead.
There was a problem hiding this comment.
The issue is directly related to pyo3. There's already a ticket filed, and it appears to be fixed in main. Once the fixed is release this clippy exception shouldn't be necessary.
There was a problem hiding this comment.
As a follow-up, could you please add an issue to remind us to remove this clippy exception later?
There was a problem hiding this comment.
Second to what @fvaleye said, would be good to add a follow up issue on github. Also a good practice to add comment in the code for temp workarounds that we plan to remove in the future.
|
I don't believe I have merge privileges for this repo. I'm happy for someone else to perform the merge. |
|
Let me do it for you! |
Description
This addresses clippy lint warnings that appeared with the 1.63.0 release of rust. Most of the changes are reasonable and straight forward. I'm unsure about the best way to resolve python/src/lib.rs. I whitelisted the check, as py03 wants pymethods to have parameters with known sizes as compile time.
Related Issue(s)
Documentation
https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq
https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref