feat: Upgrade to arrow/parquet 15 and datafusion 9 #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding to localfilesystem
… datafusion tableprovider
Co-authored-by: Christian Williams <[email protected]>
Co-authored-by: Christian Williams <[email protected]>
xianwill
changed the title
roeap
approved these changes
Jun 20, 2022
Comment on lines
168
to
175
| fn new_underlying_writer( | ||
| cursor: InMemoryWriteableCursor, | ||
| buffer: ShareableBuffer, | ||
| arrow_schema: Arc<ArrowSchema>, | ||
| writer_properties: WriterProperties, | ||
| ) -> Result<ArrowWriter<InMemoryWriteableCursor>, ParquetError> { | ||
| ArrowWriter::try_new(cursor, arrow_schema, Some(writer_properties)) | ||
| ) -> Result<ArrowWriter<ShareableBuffer>, ParquetError> { | ||
| ArrowWriter::try_new(buffer, arrow_schema, Some(writer_properties)) | ||
| } | ||
| } |
There was a problem hiding this comment.
i do remember stumbling across this before and not introduced in this PR, but wrapping this one-liner in a function does not seem to add convenience :).
There was a problem hiding this comment.
I almost changed this and a few other things in this PR, but I decided to save it for the followup. I agree it isn't useful in its current state, but I'd still like to address it next time.
| let cursor = InMemoryWriteableCursor::default(); | ||
| let mut writer = ArrowWriter::try_new(cursor.clone(), arrow_schema.clone(), None)?; | ||
| let buffer = ShareableBuffer::default(); | ||
| let mut writer = ArrowWriter::try_new(buffer.clone(), arrow_schema.clone(), None)?; |
There was a problem hiding this comment.
... particularly since we are not using that function from before here :).
houqp
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades arrow and parquet to 15 and datafusion to 9.
The parquet crate has deprecated and removed the InMemoryWriteableCursor from the public API. We still need a struct like this for streaming writes though so we can check the parquet buffer size and finalize file writes based on buffer size. For now, we need this in kafka-delta-ingest, but the delta-rs writer has a similar implementation and we want to begin using that writer soon.
The
ShareableBufferstruct I've added in this PR is similar to theInMemoryWriteableCursorbut doesn't include aCursorsince we don't currently have a need to seek. Also it uses anRwLockinstead of aMutex.In a separate PR, I plan to make some additional changes to remove obstacles for using the delta-rs writer within kafka-delta-ingest.
Related Issue(s)