Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure options #606

Merged
merged 4 commits into from
May 17, 2022
Merged

Azure options #606

merged 4 commits into from
May 17, 2022

Conversation

roeap
Copy link
Collaborator

@roeap roeap commented May 15, 2022

Description

The PR improves flexibility and ease of use for creating Adls2StorageBackaends.

  • Introduce AzureStorageOptions a typed struct to make azure config options explicit.
  • Harmonizes option handling between S3 and Azure.
  • explicitly support service principal authorization ontop of previously introduced TokenCredential

The azure backend tests were successfully executed locally.

Related Issue(s)

closes #555
closes #527
closes #554
#554 was actually done before, but should be closed anyhow

Documentation

@roeap roeap requested review from thovoll and houqp May 15, 2022 12:03
houqp
houqp previously approved these changes May 16, 2022
Copy link
Member

@houqp houqp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice clean up 👍

rust/src/storage/mod.rs Outdated Show resolved Hide resolved
@roeap roeap enabled auto-merge (squash) May 16, 2022 11:27
@roeap roeap merged commit 9216a8e into delta-io:main May 17, 2022
@roeap roeap deleted the azure-options branch May 17, 2022 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants